Re: NEW: databases/lmdb

On Mon, Jun 04 2018, Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> On Wed May 30, 2018 at 03:56:59PM +0100, Stuart Henderson wrote:
>> On 2018/05/30 16:25, Rafael Sadowski wrote:
>> > On Wed May 30, 2018 at 03:55:10PM +0200, Rafael Sadowski wrote:
>> > > Please find attached an new tarball with following changes:
>> > >
>> > > - Use MDB_WRITEMAP (hint from jca@ and sthen@.
>> > > -- All tests runs fine now
>> > > - replace OpenLDAP with Symas in COMMENT by Raf Czlonka
>> > >
>> > > After import we can patch net/knot to use databases/lmdb.
>> >
>> > Okay knot automatically picks lmdb if it's installed. Patch below.
>>
>> 2 sumbols are removed from libknot if built against external lmdb.
>>
>
> Thanks for pointing that out.
>
> New diff to update both consumers knot and baloo. Baloo needs EPOCH to
> update from 15.04.26 to 5.46.0.
>
> knot tests still green and baloo doesn't have any consumers right now.

Thanks for the knot diff, tested with a basic slave setup.

Regarding the lmdb port:
- the first "MDB" in pkg/DESCR is a bit confusing, can you please use
"LMDB" there?
- you need something like the diff below for the shlib version to be
respected.

With those points addressed, ok jca@


--- Makefile~ Wed May 30 15:40:04 2018
+++ Makefile Tue Jun 5 00:50:25 2018
@@ -22,7 +22,9 @@
WANTLIB += c pthread

USE_GMAKE = Yes
-MAKE_FLAGS = CC="${CC}" XCFLAGS="${CFLAGS}"
+MAKE_FLAGS = CC="${CC}" XCFLAGS="${CFLAGS}" \
+ SHARED_VERSION_MAJOR=${LIBlmdb_VERSION:R} \
+ SHARED_VERSION_MINOR=${LIBlmdb_VERSION:E}

WRKDIST = ${WRKDIR}/lmdb-${GH_TAGNAME}/libraries/liblmdb



--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE