On 2018/06/29 19:43, Landry Breuil wrote:
> Hi,
>
> and now that sqlite2mdoc is in, here's the diff for the integration part
> into sqlite3 port. Note the less that 10% size increase in pkg size.
>
> 1953518 sqlite3-3.24.0.tgz
> 2187305 sqlite3-3.24.0p0.tgz
The unpacked size isn't too much bigger either. OK sthen
Kristaps: one nit with sqlite2mdoc which jumped out at me on the first
page I randomly picked to see how it looks - the "new sentence new line"
mechanism results in a newline after "e.g." which means you get a double
space.
"new sentence new line" makes more sense for manuals which are
edited/diffed than these generated pages, so I'm wondering if it would
be acceptable to disable this heuristic? (just remove the lines around
1415). It would still miss things if it appears on the end of a source
line, or if we're unlikely with long-line splitting, but it does help
the common case in the sqlite comments which is "If some other error
occurs (e.g. an OOM condition)" and appears quite often.
Example page with this is sqlite3changeset_old(3) but there are a lot
more.
No comments:
Post a Comment