Re: NEW: misc/pastebinit

Updated

On Sat, Jun 30, 2018 at 4:14 AM Stuart Henderson <stu@spacehopper.org>
wrote:

> On 2018/06/29 22:57, Nathan Owens wrote:
> > After a few issues was pointed out to me thanks to Vigdis, I've updated
> the
> > package to include the changes.
> >
> > It was pointed out the license marker is weird, but would it be fine
> since
> > it uses two versions of GPL?
> >
> > On Fri, Jun 29, 2018 at 10:31 PM Nathan Owens <ndowens04.obsd@gmail.com>
> > wrote:
> >
> > > Included in attachment is pastebinit, so OpenBSD users can easily paste
> > > files or command outputs to a supported pastebin service.
> > >
> > > I've also included an update to the misc/Makefile to include the
> proposed
> > > package
> > >
> > > Also emailed upstream hoping to remove the shebang part of the patch of
> > > the package in the future
> > >
>
> : # $OpenBSD: Makefile,v 1.32 2017/11/21 00:13:00 naddy Exp $
> :
> : COMMENT = allows files or commands to be sent to a supported pastebin
>
> "or commands" isn't quite right, "command output" is more like it, but
> then the
> line is probably too long.
>
> :
> : V = 1.5
> : DISTNAME = pastebinit-${V}
> : CATEGORIES = misc
> :
> : HOMEPAGE = https://launchpad.net/pastebinit
> : MASTER_SITES =
> https://launchpad.net/pastebinit/trunk/${V}/+download/
> <https://launchpad.net/pastebinit/trunk/$%7BV%7D/+download/>
> : SEPERATE_BUILD = Yes
>
> Misspelt (and pointless for a NO_BUILD port).
>
> : #GPLv2, GPLv3
>
> "either version 2 of the License, or (at your option) any later version"
> -> this is written like:
>
> # GPLv2+
>
> : PERMIT_PACKAGE_CDROM = Yes
> :
> : NO_BUILD = Yes
> : RUN_DEPENDS = lang/python/3.6
>
> this dependency needs to come from MODULES=lang/python
>
> ..
>
> : $OpenBSD$
> :
> : Fix python shebang & fix config locations
> :
> : Index: pastebinit
> : --- pastebinit.orig
> : +++ pastebinit
> : @@ -1,4 +1,4 @@
> : -#!/usr/bin/python3
> : +#!/usr/bin/env python3
>
> use MODPY_ADJ_FILES from the python module - look at other ports or
> port-modules(7) for how it's used.
>
> : # -*- coding: utf-8 -*-
> :
> : # Author: Stéphane Graber <stgraber@ubuntu.com>
> : @@ -70,7 +70,7 @@ try:
> :
> : # Version number to show in the usage
> : version = "1.5"
> : - configfile = os.path.expanduser("~/.pastebinit.xml")
> : + configfile =
> os.path.expanduser("/usr/local/share/pastebinit/pastebinit.xml")
>
> That seems wrong to me, it is documented as looking for this file in ~
> and from reading code it looks like it should handle its absence?
>
> :
> : # Custom urlopener to handle 401's
> : class pasteURLopener(FancyURLopener):
> : @@ -86,7 +86,7 @@ try:
> : # - user's overrides in ~/.pastebin.d
> : # Files found later override files found earlier.
> : pastebind = {}
> : - for confdir in ['/usr/share/pastebin.d', '/etc/pastebin.d',
> : + for confdir in ['/usr/local/share/pastebinit/pastebin.d',
> '/etc/pastebin.d',
>
> Patch to use ${PREFIX} not /usr/local here. Use ${SYSCONDIR} not /etc.
> Use SUBST_CMD to replace them.
>
>
> : '/usr/local/etc/pastebin.d',
> : os.path.expanduser('~/.pastebin.d'),
> : os.path.join(
> :
>
> Also might be worth listing default-supported pastebin services in
> pkg/DESCR.
>