On 2018/06/01 10:02, Stuart Henderson wrote:
> On 2018/06/01 09:24, Martijn van Duren wrote:
> > On 05/31/18 15:25, Stuart Henderson wrote:
> > > On 2018/05/31 13:53, Martijn van Duren wrote:
> > >> The current patch removes the check altogether, this patch adds an
> > >> extra check to make sure libodbc isn't linked to the SAPIs.
> > >>
> > >> This is similar to how other libraries setup the
> > >> PHP_ADD_LIBRARY_WITH_PATH in their config.m4.
> > >
> > > Seems an unnecessary change to the port, perhaps upstream will take it though.
> > >
> >
> > Both seem to work, but since I'm cleaning up the patches it seemed like
> > little effort to put in the correct semantics.
> >
>
> This is replacing a simpler patch with a (slightly) more complicated one though.
> What is there already works, I see no need to rearrange these deckchairs.
>
PS: In *ports* that is. It would make sense for upstream though.
No comments:
Post a Comment