Hi Elias,
On Sat, Jun 30, 2018 at 07:47:19PM -0300, Elias M. Mariani wrote:
> Sorry for spamming but I added some things:
> - Test dependency to py-lxrd.
Some comments:
> # math/py-statsmodels${MODPY_FLAVOR}
What's this all about? I guess you want to pull this in eventually, but
not for now. I'd either kill it, or an the very least add a comment as
to what it's here for.
> #NO py3-mysql for now... disabled test for python3 FLAVOR
Space after the '#'. s/NO/No/
> .if ${FLAVOR:Mtest}
^ This is about the odd in-place scheme, right? I think a comment would
help to clarify.
I'm seeing test failures. Test log attached.
Otherwise this seems fine.
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
No comments:
Post a Comment