This took a while since cmake is rather new to me.
On 07/30/18 14:08, Stuart Henderson wrote:
[...]
>>> Hmm. Looking at the unpacked source there are copies of bzip2, zlib,
>>> minisat, CUDD in there so the license string could do with a bit more
>>> than just "MIT". (Of course it would be better still if it used the
>>> external copies ..)
I used the following comment line, detailing the tools/libs present in
/src and the corresponding licenses:
# MIT (abc, minisat), BSD (bzlib, CUDD), zlib
[...]
>>> The build is considerably faster if switched to cmake, the dependency
>>> generation stage of the Makefile-based build takes ages. 20s with cmake
>>> vs 1m33s for a build using ccache with a primed cache. (Still needs
>>> USE_GMAKE and either "ln -s `which ${MAKE_PROGRAM}` ${WRKDIR}/bin/make"
>>> or a patch to CMakeLists.txt).
So I added devel/cmake to the MODULES variable (I think CONFIGURE_STYLE
explicit definition is not needed).
It still uses gmake since some relevant settings are extracted from the
Makefile (which must be patched as discussed) through a specific target.
I preferred to link MAKE_PROGRAM in ${WRKDIR}/bin in order to save a
patch, using the pre-configure target (I'm not sure that it's the right
place, please confirm). MAKE_FLAGS line is not useful anymore.
do-install target required a tweak in order to take the executable from
${WRKDIR}/build-${MACHINE_ARCH}. Should I set SEPARATE_BUILD too?
Still compiles correctly on amd64, runs ok for a limited set of test-cases.
Updated tarball attached.
--
Alessandro DE LAURENZIS
[mailto:just22@atlantide.t28.net]
Web: http://www.atlantide.t28.net
LinkedIn: http://it.linkedin.com/in/delaurenzis
No comments:
Post a Comment