Re: [PATCH] databases/lbdb - enable abook support

On 2018/07/06 12:22, Raf Czlonka wrote:
> Hi all,
>
> Given that abook is in ports, could we have support for it enabled
> in lbdb, please?
>
> Regards,
>
> Raf
>
> Index: databases/lbdb/Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/lbdb/Makefile,v
> retrieving revision 1.19
> diff -u -p -r1.19 Makefile
> --- databases/lbdb/Makefile 29 Apr 2016 11:03:43 -0000 1.19
> +++ databases/lbdb/Makefile 6 Jul 2018 11:19:35 -0000
> @@ -36,7 +36,6 @@ CONFIGURE_STYLE = gnu
>
> CONFIGURE_ARGS += --libdir=${PREFIX}/lib/lbdb \
> --with-libiconv-prefix=${LOCALBASE} \
> - --without-abook \
> --without-addr-email \
> --without-niscat \
> --without-gpg \
>

A bit more than that is needed, but it seems reasonable to add
it, the extra dependency isn't too heavy.

Slight Makefile reordering while there. Does this work for you?

Index: Makefile
===================================================================
RCS file: /cvs/ports/databases/lbdb/Makefile,v
retrieving revision 1.19
diff -u -p -r1.19 Makefile
--- Makefile 29 Apr 2016 11:03:43 -0000 1.19
+++ Makefile 6 Jul 2018 23:39:51 -0000
@@ -4,6 +4,7 @@ COMMENT-main = "little brother's databa
COMMENT-ldap = LDAP support for lbdb

VERSION = 0.40
+REVISION-main = 0

DISTNAME = lbdb_${VERSION}
PKGNAME-main = lbdb-${VERSION}
@@ -18,25 +19,27 @@ MULTI_PACKAGES = -main -ldap
# GPLv2+
PERMIT_PACKAGE_CDROM = Yes

+WANTLIB-main = c iconv
+
+MASTER_SITES = http://www.spinnaker.de/debian/
+
+BUILD_DEPENDS = ${RUN_DEPENDS-main}
+LIB_DEPENDS-main = converters/libiconv
+RUN_DEPENDS-main = mail/abook
RUN_DEPENDS-ldap = databases/p5-ldap \
databases/lbdb

-LIB_DEPENDS-main = converters/libiconv
-WANTLIB-main = c iconv
LIB_DEPENDS-ldap =
WANTLIB-ldap =

-MASTER_SITES = http://www.spinnaker.de/debian/
-
MAKE_ENV = install_prefix=${WRKINST}

NO_TEST = Yes
USE_GMAKE = Yes
CONFIGURE_STYLE = gnu

-CONFIGURE_ARGS += --libdir=${PREFIX}/lib/lbdb \
+CONFIGURE_ARGS += --libdir=${PREFIX}/lib/lbdb \
--with-libiconv-prefix=${LOCALBASE} \
- --without-abook \
--without-addr-email \
--without-niscat \
--without-gpg \
Index: pkg/PLIST-main
===================================================================
RCS file: /cvs/ports/databases/lbdb/pkg/PLIST-main,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST-main
--- pkg/PLIST-main 15 Jun 2008 07:22:57 -0000 1.1.1.1
+++ pkg/PLIST-main 6 Jul 2018 23:39:51 -0000
@@ -8,6 +8,7 @@ lib/lbdb/
lib/lbdb/lbdb-munge
lib/lbdb/lbdb_bbdb_query.el
lib/lbdb/lbdb_lib
+lib/lbdb/m_abook
lib/lbdb/m_bbdb
lib/lbdb/m_fido
lib/lbdb/m_finger