On 08/29/18 16:58, Stuart Henderson wrote:
> On 2018/08/07 20:24, Charlène wrote:
>> On Mon, 6 Aug 2018 16:31:04 -0400
>> Brian Callahan wrote:
>>
>>> On 8/6/18 4:59 AM, Charlène wrote:
>>>> Hi,
>>>>
>>>> I'm proposing this XS Perl module, because it will be required in
>>>> order to update audio/abcde to its latest release.
>>>>
>>>> >From DESCR:
>>>>
>>>> MusicBrainz::DiscID is a Perl class to calculate a MusicBrainz
>>>> DiscID from an audio CD in the drive.
>>>>
>>>> Homepage: http://search.cpan.org/dist/MusicBrainz-DiscID/
>>>>
>>>> It builds and works on amd64, but i have no other architecture to
>>>> test against, so testing and comments are welcome!
>>>>
>>>> I'm also joining a small test script that gives you a link to the
>>>> MusicBrainz' table of content of the currently inserted audio CD.
>>>>
>>>> Charlène.
>>> Super minor style nit, as I understand it we prefer a space before
>>> the = for variables (this also aligns with Makefile.template).
>>>
>>> Also, do you want to be MAINTAINER?
>> Hi,
>>
>> I had to look at the XS code before giving an answer, it's a almost 1:1
>> interface to libdiscid, so i'll maintain it.
>>
>> I changed the Makefile as such.
>>
>> Charlène.
>>
>>> ~Brian
>>>
>
>
> OK sthen@
Committed, thanks!
No comments:
Post a Comment