Thursday, August 16, 2018

Re: NEW: misc/divecmd

Hi Brian,

Brian Callahan wrote on Thu, Aug 16, 2018 at 08:20:27PM -0400:
> On 08/16/18 18:54, Ingo Schwarze wrote:

>> The port looks sane to me and builds and installs fine.
>> If anybody could provide an OK, i'd like to put it in.

> 3 quick things then it's ready to be imported:
> 1. License should be tweaked to LGPLv2.1+
> 2. Usually the MASTER_SITES line goes right after WANTLIB (this also
> matches Makefile.template).
> 3. When I ran `make update-plist' the PLIST did in fact change--this
> port was still using the old RCS ID PLIST marker.
>
> With those small things addressed, this is ok for me to commit.

All done and committed.

Thanks a lot for your review!
Ingo


P.S.
I believe that item 3 makes no difference - both the old form
@comment $OpenBSD$
and the new form
@comment $OpenBSD: PLIST,v$
get rewritten to the same
@comment $OpenBSD: PLIST,v 1.1.1.1 2018/08/17 00:44:08 schwarze Exp $
when committing, as far as i understand.

But running make update-plist once again certainly did no harm
in this case. :-)

No comments:

Post a Comment