On Fri, Aug 10 2018, Solene Rapenne <solene@perso.pw> wrote:
> Jeremie Courreges-Anglas <jca@wxcvbn.org> wrote:
>> On Thu, Aug 09 2018, Solene Rapenne <solene@perso.pw> wrote:
>> > clic is a text based gopher client. It is pledged and man is included.
>>
>> Well right now you don't install the manpage.
>>
>> > clic is using colors to distinguish links types and is driven by typing
>> > the number of the link in the current menu.
>> >
>> > I want to take maintainership of clic because I'm its author.
>> >
>> > It's developped in common lisp but will only works with lang/ecl, it's a
>> > choice of me so it has a smaller memory usage and doesn't require
>> > wxallowed (lang/sbcl produce ~80Mb binaries and requires wxallowed).
>>
>> Makes sense.
>>
>> Please fix WANTLIB as noted by bcallah@. Nits: the pledge marker seems
>> to be "uses pledge()" with parens, and the next comment seems to be
>> misplaced. Didn't you mean:
>>
>> # To open HTML and other links clic doesn't understand.
>> RUN_DEPENDS = devel/xdg-utils
>>
>> ?
>>
>> Except for this, seems to work fine.
>
> - I fixed the WANTLIB thx to bcallah@
> - pledge now has parenthesis
> - man is installed
>
> the tarball is using 1.01 version
ok jca@
I understand your use of NO_TEST=Yes, but maybe you should make
run-test.sh available in the tarball instead?
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment