Index: Makefile
===================================================================
RCS file: /cvs/ports/www/p5-WebService-MusicBrainz/Makefile,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 Makefile
--- Makefile 20 Mar 2016 19:57:23 -0000 1.12
+++ Makefile 28 Aug 2018 21:53:28 -0000
@@ -1,21 +1,20 @@
# $OpenBSD: Makefile,v 1.12 2016/03/20 19:57:23 naddy Exp $
-COMMENT= interface to Music Brainz
-
-DISTNAME= WebService-MusicBrainz-0.93
+COMMENT= interface to the MusicBrainz v2.0 API
+DISTNAME= WebService-MusicBrainz-1.0.4
CATEGORIES= www
-MODULES= cpan
-PKG_ARCH= *
+MAINTAINER= Charlene Wendling <julianaito@posteo.jp>
# perl
PERMIT_PACKAGE_CDROM= Yes
+MODULES= cpan
+
+RUN_DEPENDS= www/p5-Mojo>=7.13
+
CONFIGURE_STYLE= modbuild
-RUN_DEPENDS= devel/p5-Class-Accessor>=0.30 \
- textproc/p5-XML-LibXML>=1.63 \
- www/p5-URI>=1.35 \
- www/p5-libwww
+PKG_ARCH= *
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/p5-WebService-MusicBrainz/distinfo,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 distinfo
--- distinfo 18 Jan 2015 03:15:47 -0000 1.7
+++ distinfo 28 Aug 2018 21:53:28 -0000
@@ -1,2 +1,2 @@
-SHA256 (WebService-MusicBrainz-0.93.tar.gz) = wbwSTx2X6XDXdSoJSZcQ0aR5hlgaQKzlOFKSjU0X5r0=
-SIZE (WebService-MusicBrainz-0.93.tar.gz) = 23378
+SHA256 (WebService-MusicBrainz-1.0.4.tar.gz) = asArvM8oAVUhMQg5gu3ComM4vNR6jtrLPNpMqWQfX6A=
+SIZE (WebService-MusicBrainz-1.0.4.tar.gz) = 9937
Index: patches/patch-t_Area_t
===================================================================
RCS file: patches/patch-t_Area_t
diff -N patches/patch-t_Area_t
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-t_Area_t 28 Aug 2018 21:53:28 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+Fix tests as ext:score is non existent in the xml returned.
+Index: t/Area.t
+--- t/Area.t.orig
++++ t/Area.t
+@@ -42,7 +42,7 @@ sleep(1);
+ my $s5_res = $ws->search(area => { iso => 'US-CA', fmt => 'xml' });
+ exit_if_mb_busy($s5_res);
+ ok($s5_res->find('name')->first->text eq 'California');
+-ok($s5_res->at('area')->attr('ext:score') == 100);
++ok($s5_res->at('area')->attr('ns2:score') == 100);
+ sleep(1);
+
+ done_testing();
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/www/p5-WebService-MusicBrainz/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 DESCR
--- pkg/DESCR 4 Feb 2008 20:02:54 -0000 1.1.1.1
+++ pkg/DESCR 28 Aug 2018 21:53:28 -0000
@@ -1,2 +1,2 @@
-This module will act as a factory using static methods to return
-specific web service objects.
+The WebService::MusicBrainz module provides a Perl interface to the
+musicbrainz.org v2.0 API.
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/www/p5-WebService-MusicBrainz/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 PLIST
--- pkg/PLIST 31 Mar 2011 13:57:54 -0000 1.2
+++ pkg/PLIST 28 Aug 2018 21:53:28 -0000
@@ -1,78 +1,7 @@
-@comment $OpenBSD: PLIST,v 1.2 2011/03/31 13:57:54 jasper Exp $
+@comment $OpenBSD: PLIST,v$
${P5SITE}/WebService/
${P5SITE}/WebService/MusicBrainz/
${P5SITE}/WebService/MusicBrainz.pm
-${P5SITE}/WebService/MusicBrainz/Artist.pm
-${P5SITE}/WebService/MusicBrainz/Label.pm
-${P5SITE}/WebService/MusicBrainz/Query.pm
-${P5SITE}/WebService/MusicBrainz/Release.pm
-${P5SITE}/WebService/MusicBrainz/ReleaseGroup.pm
-${P5SITE}/WebService/MusicBrainz/Response/
-${P5SITE}/WebService/MusicBrainz/Response.pm
-${P5SITE}/WebService/MusicBrainz/Response/Alias.pm
-${P5SITE}/WebService/MusicBrainz/Response/AliasList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Artist.pm
-${P5SITE}/WebService/MusicBrainz/Response/ArtistList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Disc.pm
-${P5SITE}/WebService/MusicBrainz/Response/DiscList.pm
-${P5SITE}/WebService/MusicBrainz/Response/ISRC.pm
-${P5SITE}/WebService/MusicBrainz/Response/ISRCList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Label.pm
-${P5SITE}/WebService/MusicBrainz/Response/LabelList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Metadata.pm
-${P5SITE}/WebService/MusicBrainz/Response/Puid.pm
-${P5SITE}/WebService/MusicBrainz/Response/PuidList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Rating.pm
-${P5SITE}/WebService/MusicBrainz/Response/Relation.pm
-${P5SITE}/WebService/MusicBrainz/Response/RelationList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Release.pm
-${P5SITE}/WebService/MusicBrainz/Response/ReleaseEvent.pm
-${P5SITE}/WebService/MusicBrainz/Response/ReleaseEventList.pm
-${P5SITE}/WebService/MusicBrainz/Response/ReleaseGroup.pm
-${P5SITE}/WebService/MusicBrainz/Response/ReleaseGroupList.pm
-${P5SITE}/WebService/MusicBrainz/Response/ReleaseList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Tag.pm
-${P5SITE}/WebService/MusicBrainz/Response/TagList.pm
-${P5SITE}/WebService/MusicBrainz/Response/Track.pm
-${P5SITE}/WebService/MusicBrainz/Response/TrackList.pm
-${P5SITE}/WebService/MusicBrainz/Response/UserRating.pm
-${P5SITE}/WebService/MusicBrainz/Response/UserTag.pm
-${P5SITE}/WebService/MusicBrainz/Response/UserTagList.pm
-${P5SITE}/WebService/MusicBrainz/Track.pm
+${P5SITE}/WebService/MusicBrainz/Request.pm
@man man/man3p/WebService::MusicBrainz.3p
-@man man/man3p/WebService::MusicBrainz::Artist.3p
-@man man/man3p/WebService::MusicBrainz::Label.3p
-@man man/man3p/WebService::MusicBrainz::Query.3p
-@man man/man3p/WebService::MusicBrainz::Release.3p
-@man man/man3p/WebService::MusicBrainz::ReleaseGroup.3p
-@man man/man3p/WebService::MusicBrainz::Response.3p
-@man man/man3p/WebService::MusicBrainz::Response::Alias.3p
-@man man/man3p/WebService::MusicBrainz::Response::AliasList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Artist.3p
-@man man/man3p/WebService::MusicBrainz::Response::ArtistList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Disc.3p
-@man man/man3p/WebService::MusicBrainz::Response::DiscList.3p
-@man man/man3p/WebService::MusicBrainz::Response::ISRC.3p
-@man man/man3p/WebService::MusicBrainz::Response::ISRCList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Label.3p
-@man man/man3p/WebService::MusicBrainz::Response::LabelList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Metadata.3p
-@man man/man3p/WebService::MusicBrainz::Response::Puid.3p
-@man man/man3p/WebService::MusicBrainz::Response::PuidList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Rating.3p
-@man man/man3p/WebService::MusicBrainz::Response::Relation.3p
-@man man/man3p/WebService::MusicBrainz::Response::RelationList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Release.3p
-@man man/man3p/WebService::MusicBrainz::Response::ReleaseEvent.3p
-@man man/man3p/WebService::MusicBrainz::Response::ReleaseEventList.3p
-@man man/man3p/WebService::MusicBrainz::Response::ReleaseGroup.3p
-@man man/man3p/WebService::MusicBrainz::Response::ReleaseGroupList.3p
-@man man/man3p/WebService::MusicBrainz::Response::ReleaseList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Tag.3p
-@man man/man3p/WebService::MusicBrainz::Response::TagList.3p
-@man man/man3p/WebService::MusicBrainz::Response::Track.3p
-@man man/man3p/WebService::MusicBrainz::Response::TrackList.3p
-@man man/man3p/WebService::MusicBrainz::Response::UserRating.3p
-@man man/man3p/WebService::MusicBrainz::Response::UserTag.3p
-@man man/man3p/WebService::MusicBrainz::Response::UserTagList.3p
-@man man/man3p/WebService::MusicBrainz::Track.3p
+@man man/man3p/WebService::MusicBrainz::Request.3p
On Tue, 28 Aug 2018 16:18:12 -0400
Brian Callahan wrote:
>
> On 08/08/18 07:51, Charlène wrote:
> > On Wed, 8 Aug 2018 09:17:52 +0100
> > Stuart Henderson wrote:
> >
> >> On 2018/08/07 20:27, Charlène wrote:
> >>> On Mon, 6 Aug 2018 10:52:23 +0200
> >>> Charlène wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> I'm currently working on an update for audio/abcde, that requires
> >>>> this update and a new port (audio/p5-MusicBrainz-DiscID).
> >>>>
> >>>> Abcde wants WebService::MusicBrainz v1.0.4, the latest release as
> >>>> i'm writing this.
> >>>>
> >>>> Many things changed, i'm quoting upstream:
> >>>>
> >>>> « Version 1.0 and future releases are not backward compatible
> >>>> with pre-1.0 releases. This is a complete re-write using version
> >>>> 2.0 of the MusicBrainz API and Mojolicious. »
> >>>>
> >>>> So i've checked with sqlports, no other ports than the future
> >>>> updated audio/abcde depends on this port.
> >>>>
> >>>> I'm also joining a very basic script, if you want to test the
> >>>> module.
> >>>>
> >>>> Comments and OK are welcome!
> >>>>
> >>>> Charlène.
> >>> Hi,
> >>>
> >>> I'm proposing myself as MAINTAINER for this port, so i'm joining a
> >>> new diff.
> >>>
> >>> Charlène.
> >> +LIB_DEPENDS= www/p5-Mojo>=7.13
> >>
> >> LIB_DEPENDS is the wrong thing for Perl modules, they are
> >> RUN_DEPENDS.
> >>
> >> LIB_DEPENDS without an associated WANTLIB is always wrong.
> >>
> >>
> > Hi Stuart,
> >
> > Thanks for reviewing, i'm taking note of it and changed accordingly,
> > also removed a spacing inconsistency on MAINTAINER line.
> >
> > I've retested those changes, it builds and runs fine on my amd64
> > machine.
> >
> > Charlène.
>
> Some of the tests fail here though I'm not sure how much that matters.
> Stuart, you can go commit the update if you want. ok for me.
> ~Brian
>
Hi,
I looked at the issue, Area.t fails at line 45 because the API returns
something different than expected, even by the doc [1]. ext:score is not
there, it's ns2:score now, see the live result here [2].
The final target and only consumer that would be an upgraded
audio/abcde doesn't use area queries. If needed i'm joining an alternate
version of the port with the patched test (i'll need it for upstream
anyway):
===> Regression tests for p5-WebService-MusicBrainz-1.0.4
t/Area.t ....... ok
t/Artist.t ..... ok
t/Label.t ...... ok
t/Recording.t .. ok
t/Release.t .... ok
All tests successful.
Files=5, Tests=76, 38 wallclock secs ( 0.05 usr 0.08 sys + 1.99 cusr
0.54 csys = 2.66 CPU) Result: PASS
Charlène.
[1]
https://musicbrainz.org/doc/Development/XML_Web_Service/Version_2/Search
[2] http://musicbrainz.org/ws/2/area/?query=%22California%22
No comments:
Post a Comment