Re: devel/libinotify: why the custom directories?

On Fri, Sep 28, 2018 at 11:53:48AM +0200, Antoine Jacoutot wrote:
>
> It's the kqueue implementation in it that is half broken and unmaintained (and
> that was written for BSD, so definitely *not* NIH). If someone can have a look
> at it and make sure it's working fine, then we can open the usage to a broader
> amount of ports.

Maybe starting by updating the port ?

We have 20170711 and the latest is 20180201.

https://github.com/libinotify-kqueue/libinotify-kqueue/releases/tag/20180201

1. Directory diffing has been rewritten. No more memory hungry shallow
lists allocations/deallocations

2. Fix compilation on platforms where kevent.data size is bigger than
void * (issue #4)

3. Workaround sporadic crashes caused by reversing of kevent order
(issue #5)


$ make test
...
--------------------
Run: 125
Passed: 109
Failed: 0
Skipped: 16


The diff below is just a base for more testing. I have *not* tested the
reverse-dependencies:

devel/hs-hinotify
devel/py-pyinotify
devel/py-pyinotify,python3
graphics/sxiv
net/owncloudclient
net/seafile/seafile
sysutils/incron
sysutils/inotify-tools
sysutils/lsyncd
x11/kde4/libs,-main
x11/xmobar

--
Sebastien Marie


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libinotify/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- Makefile 3 Aug 2018 07:07:44 -0000 1.10
+++ Makefile 28 Sep 2018 10:21:58 -0000
@@ -4,10 +4,10 @@ COMMENT = kevent based inotify

GH_ACCOUNT = libinotify-kqueue
GH_PROJECT = libinotify-kqueue
-GH_TAGNAME = 20170711
+GH_TAGNAME = 20180201
PKGNAME = libinotify-${GH_TAGNAME}

-SHARED_LIBS = inotify 2.1
+SHARED_LIBS = inotify 3.0

CATEGORIES = devel

Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/libinotify/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo 30 Aug 2017 05:37:36 -0000 1.7
+++ distinfo 28 Sep 2018 10:09:05 -0000
@@ -1,2 +1,2 @@
-SHA256 (libinotify-kqueue-20170711.tar.gz) = 9/xo3TbAf7Mwh8lB6+kQKNfFDzcoLouX1Hh8DMhXrbw=
-SIZE (libinotify-kqueue-20170711.tar.gz) = 71707
+SHA256 (libinotify-kqueue-20180201.tar.gz) = Ffpt6LM7tzcXdVzpVm91cgmoVcogyT4gnG37sWl1mbI=
+SIZE (libinotify-kqueue-20180201.tar.gz) = 71808