Wednesday, September 26, 2018

Re: New: py-http_ece

Hi Stuart --

On 09/26/18 05:19, Stuart Henderson wrote:
> On 2018/09/25 21:15, Pamela Mosiejczuk wrote:
>> There are no tests included, but the regression test structure is not empty.
>> Per off-list discussion with bcallah@ and danj@, I've nonetheless set
>> NO_TEST=Yes, as running 'make test' with python2 downloads a flake8 package
>> through pip.
> flake8 should be set as a test dependency. If it's already installed then
> this should stop it from being downloaded at test time.
>

This was my advice. However, flake8 being installed doesn't entirely
stop it from being downloaded.
If you run
env FLAVOR=python3 make test
then flake8 will not be downloaded (provided you already have it installed).
However,
make test
will still download a python2 pip of flake8, even if flake8 is installed.

So my guess is there needs to be some patch for that, though I haven't
had the time to look at it.

~Brian

No comments:

Post a Comment