Re: [NEW] security/ssss

Thank you very much for your inputs Solene & Stuart.

On Wed, Sep 26, 2018 at 03:59:08PM +0100, Stuart Henderson wrote:
> On 2018/09/26 16:53, Solene Rapenne wrote:
> > hello
> >
> > portcheck reports hardcoded paths in Makefile and port-lib-depend-check reports
> > missing c in WANTLIB
> >
> > here is a diff to your makefile to fix it
> >
> > ok solene@ with the diff applied
> >
> > thank you for porting this, seems very useful :)
> >
> >
> > --- Makefile.orig Wed Sep 26 16:50:25 2018
> > +++ Makefile Wed Sep 26 16:51:01 2018
> > @@ -14,10 +14,10 @@
> >
> > MASTER_SITES= http://point-at-infinity.org/ssss/
> >
> > -WANTLIB += gmp
> > +WANTLIB += c gmp
> > LIB_DEPENDS = devel/gmp
> >
> > -MAKE_FLAGS= CC="${CC} -I/usr/local/include -L/usr/local/lib"
> > +MAKE_FLAGS= CC="${CC} -I${LOCALBASE}/include -L${LOCALBASE}/lib"
> >
> > ALL_TARGET= ssss-split ssss-combine
> >
> >
>
> Please zap the trailing . in COMMENT, and reorder lines according to
> Makefile.template.
>
> Also it needs to be taught to honour CFLAGS, currently it hardcodes -O2,
> and avoid stripping if DEBUG is set.
>

I removed the strip statement completely.
New .tgz attached.