Monday, October 01, 2018

Re: sysutils/exa: unbreak aarch64

On 2018 Oct 01 (Mon) at 06:36:07 +0200 (+0200), Sebastien Marie wrote:
:On Sun, Sep 30, 2018 at 04:39:34PM -0600, phessler@openbsd.org wrote:
:> bulk build on arm64.ports.openbsd.org
:> started on Fri Sep 28 08:31:30 MDT 2018
:> finished at Sun Sep 30 16:36:21 MDT 2018
:> lasted 03D01h04m
:> done with kern.version=OpenBSD 6.4-beta (GENERIC.MP) #195: Fri Sep 28 00:09:50 MDT 2018
:>
:> built packages:8312
:> Sep 28:3347
:> Sep 29:2251
:> Sep 30:2713
:>
:> build failures: 35
:> [...]
:> http://build-failures.rhaalovely.net/aarch64/2018-09-28/sysutils/exa.log
:> [...]
:>
:
:Hi,
:
:sysutils/exa is failing on aarch64 because the 0.8.0 version (latest)
:use an "old" Rust libc where definition for openbsd-unknown-aarch64 are
:absent.
:
:It is patched upstream https://github.com/ogham/exa/pull/413, but there
:is still no release with it.
:
:The following diff make the build to use newer libc by forcing
:the use of libc-0.2.43.
:
:Still build on amd64.
:
:Thanks.
:--
:Sebastien Marie
:

this looks OK to me.

Side question, why are these versions hardcoded in the makefile?
Shouldn't they just use the latest version?


:
:Index: Makefile
:===================================================================
:RCS file: /cvs/ports/sysutils/exa/Makefile,v
:retrieving revision 1.1.1.1
:diff -u -p -r1.1.1.1 Makefile
:--- Makefile 27 Apr 2018 09:43:18 -0000 1.1.1.1
:+++ Makefile 1 Oct 2018 04:31:32 -0000
:@@ -5,6 +5,7 @@ COMMENT = ls alternative written in Rus
: GH_ACCOUNT = ogham
: GH_PROJECT = exa
: GH_TAGNAME = v0.8.0
:+REVISION = 0
:
: CATEGORIES = sysutils
:
:@@ -35,7 +36,7 @@ MODCARGO_CRATES += idna-0.1.4 # MIT/Apac
: MODCARGO_CRATES += iso8601-0.1.1 # MIT
: MODCARGO_CRATES += kernel32-sys-0.2.2 # MIT
: MODCARGO_CRATES += lazy_static-0.2.8 # MIT/Apache-2.0
:-MODCARGO_CRATES += libc-0.2.30 # MIT/Apache-2.0
:+MODCARGO_CRATES += libc-0.2.43 # MIT/Apache-2.0
: MODCARGO_CRATES += libgit2-sys-0.6.14 # MIT/Apache-2.0
: MODCARGO_CRATES += libz-sys-1.0.16 # MIT/Apache-2.0
: MODCARGO_CRATES += locale-0.2.2 # MIT
:@@ -78,6 +79,8 @@ MODCARGO_CRATES += vcpkg-0.2.2 # MIT/Apa
: MODCARGO_CRATES += winapi-0.2.8 # MIT
: MODCARGO_CRATES += winapi-build-0.1.1 # MIT
: MODCARGO_CRATES += zoneinfo_compiled-0.4.5 # MIT
:+
:+MODCARGO_CRATES_UPDATE += libc
:
: CONFIGURE_STYLE = cargo
: SEPARATE_BUILD = Yes
:Index: distinfo
:===================================================================
:RCS file: /cvs/ports/sysutils/exa/distinfo,v
:retrieving revision 1.1.1.1
:diff -u -p -r1.1.1.1 distinfo
:--- distinfo 27 Apr 2018 09:43:18 -0000 1.1.1.1
:+++ distinfo 1 Oct 2018 04:31:32 -0000
:@@ -16,7 +16,7 @@ SHA256 (cargo/idna-0.1.4.tar.gz) = AUspg
: SHA256 (cargo/iso8601-0.1.1.tar.gz) = EdxGT4xvF1ldGRRHycZVkpiy0CPW+EakojrH6jxGxHc=
: SHA256 (cargo/kernel32-sys-0.2.2.tar.gz) = dQdiSylINDHAui2Crs6Mps26k4K/9N3Q90kFYMBWCY0=
: SHA256 (cargo/lazy_static-0.2.8.tar.gz) = OzdUWrcm3YM+xkIKq6gjHFsyCBS5AprVhVVdKgPpT78=
:-SHA256 (cargo/libc-0.2.30.tar.gz) = I3DKB+wziTnjVkQ9rCKW9YFFPDX+Hjo+0GAjxJQ1+RU=
:+SHA256 (cargo/libc-0.2.43.tar.gz) = duOj7xcvGguan/DdFJGuXmyUi5RHmjAhgZun2GDIZF0=
: SHA256 (cargo/libgit2-sys-0.6.14.tar.gz) = wA9uW8P7K1+H516ND9SuZyDVXz7iPTibfGyuMPjbjbE=
: SHA256 (cargo/libz-sys-1.0.16.tar.gz) = P91k747mUhhWdEVcHUULg8vIrYlWJdVDtTJNkj+C5Ng=
: SHA256 (cargo/locale-0.2.2.tar.gz) = X9vkkqnAI42pAKEWXEL8UGcWHOKSZ4pv6Akh8w/jB/0=
:@@ -78,7 +78,7 @@ SIZE (cargo/idna-0.1.4.tar.gz) = 289112
: SIZE (cargo/iso8601-0.1.1.tar.gz) = 7770
: SIZE (cargo/kernel32-sys-0.2.2.tar.gz) = 24537
: SIZE (cargo/lazy_static-0.2.8.tar.gz) = 9950
:-SIZE (cargo/libc-0.2.30.tar.gz) = 214259
:+SIZE (cargo/libc-0.2.43.tar.gz) = 353810
: SIZE (cargo/libgit2-sys-0.6.14.tar.gz) = 4659537
: SIZE (cargo/libz-sys-1.0.16.tar.gz) = 603527
: SIZE (cargo/locale-0.2.2.tar.gz) = 18910
:

--
Now and then an innocent person is sent to the legislature.

No comments:

Post a Comment