Re: [NEW] devel/py-arrow 0.12.1 (cookiecutter porting cont.)

Hi,

On Sun, Nov 25 2018, Edward Lopez-Acosta <elopezacosta@gmail.com> wrote:
> py-chai looks to have been merged, no new version for this port?
> Other than the fixed typo, any other changes needed?

Two things caught my eye:

1. the python2 flavor needs devel/py-backports-functools-lru-cache, else
the test target tries to fetch that from pypi (this fails by default
with PORTS_PRIVSEP=Yes).

2. why use a custom test target?

Except for this, LGTM.


--- Makefile.orig Wed Nov 21 01:00:43 2018
+++ Makefile Tue Nov 27 13:15:12 2018
@@ -25,7 +25,8 @@ TEST_DEPENDS = ${RUN_DEPENDS} \
FLAVORS += python3
FLAVOR ?=

-do-test:
- cd ${WRKSRC} && ${MODPY_BIN} setup.py test
+.if !${FLAVOR:Mpython3}
+TEST_DEPENDS += devel/py-backports-functools-lru-cache
+.endif

.include <bsd.port.mk>

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE