port for vapier/pcalc

This is my first time porting, so apologies in advance for anything I
might have missed. I've been working on a port of pcalc
(https://github.com/vapier/pcalc), and I think it's nearly ready,
however there are few remaining bits that I would appreciate some
guidance on before the port is ready to be committed.

More general feedback on style or adherence to best practice is welcome
also, as I hope to package some other software in the near future.

The current state of my Makefile follows, annotated with comments

regarding issues I would like help with. As it stands, the port works,

and the package can be built and installed, but the tests do

not work.


Thank you in advance for your help and feedback!



# $OpenBSD: Makefile.template,v 1.78 2018/07/09 15:00:06 jca Exp $
# TODO: does the above need to be modified?

V = 4
COMMENT = Programmers calculator, command line utility.
DISTNAME = pcalc-${V}
PKGNAME = pcalc-$V
GH_ACCOUNT =    vapier
GH_PROJECT =    pcalc
GH_TAGNAME =    v4
CATEGORIES = math
HOMEPAGE = http://pcalc.sourceforge.net/
MAINTAINER = Charles Daniels <charles@cdaniels.net>

# TODO: is this the correct way to indicate licensing?
# License is GPLv2 only

# TODO: can GPLv2 packages be distributed on the CDROM?
PERMIT_PACKAGE_CDROM =    Yes

WANTLIB = c m

# TODO: flex is also used - pretty sure this is part of the bison package?
BUILD_DEPENDS = devel/bison

# TODO: I think this is the "hardcoded paths" that portcheck reports - do
# these need to be changed?
MAKE_FLAGS = BINDIR=/usr/local/bin/
FAKE_FLAGS = BINDIR=/usr/local/bin/
TEST_FLAGS = BINDIR=/usr/local/bin/

USE_GMAKE =        Yes

# TODO: currently broken, throws the error
#
#    Provide an AUTOCONF_VERSION environment variable, please
#
# Not sure what the most correct way to handle this is, it doesn't look like
# there is a 'TEST_ENV', and even if so, how to determine the
AUTOCONF_VERSION
# value?
TEST_TARGET = check test

# TODO: do I need to explicitly add autoconf to TEST_DEPENDS?

.include <bsd.port.mk>