On Thu, Nov 08, 2018 at 10:22:13AM +0200, Timo Myyrä wrote:
> Here's updated version for the gzdoom to latest version.
> The fluidsynth isn't forced dependency, if user wants to use it, it must be
> installed and configured with soundfont separately.
Thanks for your efforts on gzdoom. I would like to get this moving
forward and see the port finally imported.
A couple of comments:
- The BUILD_DEPENDS should be removed, they are pulled by devel/sdl2
- pkg/PLIST.orig should be removed
- portcheck complains that pkg/README does not have $OpenBSD$ RCS tag at
the top
- We should probably mention in the README that an IWAD file is needed,
you can have a look at games/prboom for an example
Also, it seems that the two patches are unnecessary? And that we can
also remove the following line from the port Makefile?
CONFIGURE_ARGS += -DFLUIDSYNTHLIB1="libfluidsynth.so"
Lastly, I wonder if it wouldn't be better to link against fluidsynth,
add audio/generaluser-gs-soundfont in RUN_DEPENDS, and finally patch
src/gameconfigfile.cpp so it automatically finds the SoundFont banks.
This would result in a fully functional port playing music out of the
box, without requiring any manual fiddling. Any thoughts on this?
No comments:
Post a Comment