Wednesday, December 12, 2018

Re: powerpc bulk build report

On 12/12/18 3:51 PM, Charlene Wendling wrote:
> On Tue, 11 Dec 2018 16:29:13 -0700 (MST)
> landry@openbsd.org wrote:
>
>
>> http://build-failures.rhaalovely.net//powerpc/2018-12-01/games/prboom-plus.log
> Hi,
>
> The diff says it all ;) As sparc64 has the same issue, it should fix the
> build there as well. The build log is here [1].
>
> Lightly tested [2], sadly (i have motion sickness when playing FPSes).
>
> Charlène.
>
> [1] http://ix.io/1vSK
> [2] https://bsd.network/web/statuses/101230014606063596
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/prboom-plus/Makefile,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 Makefile
> --- Makefile 4 Sep 2018 12:46:13 -0000 1.5
> +++ Makefile 12 Dec 2018 20:06:05 -0000
> @@ -12,6 +12,12 @@ MAINTAINER = Ryan Freeman <ryan@slipgate
> # GPLv2+
> PERMIT_PACKAGE_CDROM = Yes
>
> +# undefined reference to `__builtin_bswap32'
> +# requires gcc >= 4.3 for gcc4 archs.
> +.if ${MACHINE_ARCH} == "powerpc" || ${MACHINE_ARCH} == "sparc64"
> +COMPILER = ports-gcc
> +.endif
> +
> BUILD_DEPENDS = archivers/unzip
>
> WANTLIB += SDL c m pthread GL GLU SDL_mixer SDL_net
>

I think it would be better if you kept the same comment but simplified
the rest to:
COMPILER = base-clang ports-gcc

Since that's effectively what you're asking for (and is more
generalizable to all archs).

~Brian

No comments:

Post a Comment