On Mon, Jan 07, 2019 at 01:48:47AM +0100, Charlene Wendling wrote:
> On Sun, 6 Jan 2019 16:55:54 -0700
> Andrew Hewus Fresh wrote:
>
> > On Sat, Dec 29, 2018 at 11:47:43AM +0100, Charlene Wendling wrote:
> > > Hi ports,
> > >
> > > Here is an update for Data::FormValidator that fixes the build with
> > > our future Perl 5.28, and unbreaks tests with our current Perl.
> >
> > The documentation in the README.pod is the same as as what is in
> > Data/Validator.pm and so I think we should avoid installing it as
> > Data::README is not really part of this namespace and confuses things.
> >
> > Avoid installing that and this is OK with me.
> >
>
> [snip]
>
> Agreed.
>
> This is what i can do to the best of my knowledge.
>
> It builds and installs properly, and 'make test' Pod coverage still
> passes.
I would rather not install Data::Readme.3p either as it is the same
content as Data::FormValidator.3p other than the name and the latter
has a much more useful name.
I saw that one of the other recent updates had avoided installing a
README, but I think your way of just deleting it after is probably
better than the patch, unless someone feels like submitting the patch
upstream.
https://metacpan.org/diff/file?target=BDFOY/Test-File-1.43/&source=BDFOY%2FTest-File-1.42
l8rZ,
--
andrew - http://afresh1.com
Hey! It compiles! Ship it!
No comments:
Post a Comment