-cc the bouncing mail address. $MAINTAINER has other ports, we should
deal with them somehow.
On Wed, Jan 30 2019, Solene Rapenne <solene@perso.pw> wrote:
> Hi!
Hi Solene,
> The following diff update scrot to what seems to be the most recent source
> repository of it https://github.com/slabua/scrot
>
> Upstream seens dead, the HOMEPAGE doesn't exist anymore.
Are there other systems that have switched to this upstream?
> I reviewed manually the commits since our version, I found nothing appearing
> harmful. What's interesting in this latest version is the addition of the -r
> flag to move/resize the selection square when using -s option.
>
> I added a pledge support too. It requires to be enabled after X11 stuff because
> of shmget not being in plegde, so that fail whatever if the pledge happens
> before the X11 stuff.
>
> I used a commit id as the last release is from 2013 which is more recent than
> our current version but lack some commits like for the -r flag. I can host the
> tarball if required, I already host a tarball for games/tome4, I have a server
> ready for that.
>
> Some WANTLIB changed has reported to port-lib-depends-check
>
> I had to patch Makefile.in as install_docsDATA wasn't a valid target and was
> failing,
So that's a technical problem. This repo contains autotools source and
product files. Looks like they aren't managed properly. Both
configure.in and configure.ac were added in the initial commit and
configure.in hasn't been gc'ed since. This is a mess, and I think that
this new upstream should get its autotools things together before
relying on them.
> I also removed the docs files as they are useless (licence is
> outdated,
How is the license outdated? README.md[1] says MIT which looks like
a valid description of what's in COPYING[2] and in the source files
(except that the conditions of the MIT license as published by the
OSI[3] is less explicit.). We should amend our license marker.
> todo is a useless one line) and that we don't usually include those
> kind of files in ports.
I think that actively removing a license file is clearly a bad move.
The above copyright notice and this permission notice shall be included
in all copies of the Software and its documentation and acknowledgment
shall be given in the documentation and software packages that this
Software was used.
> The -r flag isnt' recognized with the short flag, I added a patch to add it to
> the opts parsing, the --resize works with the original source. I will try to
> send it upstream.
Please do.
> The man page is slightly modified in this version, which could be worrying
> users maybe?
I don't think it's a problem.
> Here is the text:
>
> This is a non-official version of scrot.
> Email -r option bugs/feature requests to
> Philippe Proulx <eeppeliteloop@gmail.com>
>
> This version of scrot is a merge of various features I found online.
> For informations about the repository please refer to
> https://github.com/slabua/scrot.
> Salvatore La Bua <slabua@gmail.com>
[1] https://github.com/slabua/scrot/blob/master/README.md
[2] https://github.com/slabua/scrot/blob/master/COPYING
[3] https://opensource.org/licenses/MIT
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment