Re: UPDATE: security/sshguard 1.5 --> 2.3.0

On Thu, Jan 03, 2019 at 12:24:04PM +0100, Gonzalo L. Rodriguez wrote:
> On Wed, 02 Jan 2019 at 10:56:39 +0100, Andreas Kusalananda Kähäri wrote:
> > On Tue, Jan 01, 2019 at 07:03:36PM +0100, Remi Pointel wrote:
> > > On 12/24/18 8:24 PM, Andreas Kusalananda Kähäri wrote:
> > > > Just resending this.
> > > >
> > > > I got some comments from Stuart Henderson on a previous iteration of
> > > > this, and the issues that he mentioned (unorthodox HUP for terminating
> > > > the service, and various other fixes to the Makefile) have all been
> > > > resolved. The weird does-not-start-on-boot issue that the 1.5 release
> > > > apparently also has (according to some that followed up earlier, and
> > > > that I spent some time debugging when I packaged 2.2.0) has been
> > > > resolved by ignoring HUP in a couple of places.
> > > >
> > > > Regards
> > >
> > > Hi,
> > >
> > > sounds good to me, just remove the "NO_TEST = Yes" because there are
> > > regression tests.
> > >
> > > Cheers,
> > >
> > > Remi.
> >
> > I enabled the tests. The 147 supplied tests runs and passes (no fails).
> > The tests do not require any additional dependencies.
> >
> > New diff attached. Thanks!
> >
> >
> > --
> > Andreas Kusalananda Kähäri,
> > National Bioinformatics Infrastructure Sweden (NBIS),
> > Uppsala University, Sweden.
>
> > Index: Makefile
[cut]
> rc_reload=NO
>
> I am kinda OK with this, after the:
>
> /etc/rc.d/sshguard -fd stop
>
> $ ps auwx | grep sshguard
> root 37238 0.0 0.1 840 664 p1 Ip 12:19PM 0:00.01 /bin/sh
> /usr/local/sbin/sshguard
>
> Not quite dead, you have the same on your setup?
>
>
>
> --
> Sending from my toaster.


This is expected. All parts of the daemon has died at that stage, and
the only thing left running in the log reader (tail). It too will stop
as soon as it notices that nothing is reading from the other end of the
pipe that it's writing to. It will typically terminate as soon as the
next log message is written to /var/log/authlog.

Andreas

--
Andreas Kusalananda Kähäri,
National Bioinformatics Infrastructure Sweden (NBIS),
Uppsala University, Sweden.