Thursday, January 31, 2019

Re: [UPDATE]: shells/yash 2.44 (2017-01-17) -> 2.48 (2018-12-22)

Andreas Kusalananda Kähäri:

> You'll find a patch for an update to the shells/yash port attached.

Thank you. The way upstream publishes new releases doesn't work
with portroach and, honestly, I had forgotten about the port.

> (BTW, there's an earlier srand() call in the same file, but maybe
> this should not be changed to srand_deterministic()?)

In the upstream code, there are two srand() calls, corresponding
to two different uses of the RANDOM variable. By default, $RANDOM
expands to a truly random number. We initialize this use with
srand(). However, RANDOM can also be set to a value, which then
serves as a seed for a deterministic pseudo-random sequence by
subsequent $RANDOM references. We initialize this second use with
srand_deterministic().

You did not try to run the regression tests. I have, and now I'm
looking into the failures...

--
Christian "naddy" Weisgerber naddy@mips.inka.de

No comments:

Post a Comment