Thursday, February 28, 2019

Extra graphics/nomacs dependency

> Hello Rafael,

> I've recently started coming across webp [1] image files (which use the RIFF
> format). Our nomacs installation can't handle them in its current state, but
> simply installing qtimageformats is enough for nomacs to deal with them.

> I wonder if it might be worth adding x11/qt5/qtimagefomrats as a run-time
> dependency to nomacs so that it can handle webp (and, probably, other image
> formats)?


> Laurie

> [1] https://developers.google.com/speed/webp/

Thanks Laurence for the report. Diff below adds qtimageformats as
RUN_DEPENDS and tweaks some s/=/+=/ which I prefer in MODULES context.

nomacs+qtimageformats works quite well here.

Feedback/OK?

RS

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/nomacs/Makefile,v
retrieving revision 1.19
diff -u -p -u -p -r1.19 Makefile
--- Makefile 8 Sep 2018 06:56:45 -0000 1.19
+++ Makefile 27 Feb 2019 01:26:40 -0000
@@ -5,7 +5,7 @@ COMMENT = small and fast Qt image viewer
GH_ACCOUNT = nomacs
GH_PROJECT = nomacs
GH_TAGNAME = 3.10.2
-REVISION = 0
+REVISION = 1

CATEGORIES = graphics

@@ -25,9 +25,10 @@ WANTLIB += opencv_imgproc quazip5 raw ti
MODULES = devel/cmake \
x11/qt5 \

-RUN_DEPENDS = devel/desktop-file-utils
+RUN_DEPENDS += devel/desktop-file-utils \
+ x11/qt5/qtimageformats

-LIB_DEPENDS = archivers/quazip,qt5 \
+LIB_DEPENDS += archivers/quazip,qt5 \
graphics/exiv2 \
graphics/lcms2 \
graphics/libraw \
@@ -35,9 +36,8 @@ LIB_DEPENDS = archivers/quazip,qt5 \
graphics/tiff \
x11/qt5/qtsvg

-CONFIGURE_ARGS = -DUSE_SYSTEM_QUAZIP:Bool=ON \
- -DDISABLE_QT_DEBUG:Bool=ON \
- -DENABLE_TRANSLATIONS:Bool=ON
+CONFIGURE_ARGS += -DUSE_SYSTEM_QUAZIP=ON \
+ -DENABLE_TRANSLATIONS=ON

WRKDIST = ${WRKDIR}/${PKGNAME}/ImageLounge

No comments:

Post a Comment