Re: [NEW] Notmuch 0.28.3

On 2019/03/29 20:22, Enric Morales wrote:
>
> Dear ports@,
>
> Attached you'll find the port for notmuch 0.28.3, a mail indexer similar
> to mu4e or sup. It also builds the bindings necessary for interfacing it
> with Emacs, Python 2.7 or 3.6 (only 3.6 tested with afewmail). With a
> few minor patches to fix some gz calls, to not compress the manpages and
> to call GNU Make instead of base Make, notmuch builds (build and
> portcheck log in the attachments) and runs perfectly in OpenBSD
> -CURRENT. I have been using it for the last 5 months. I am also
> volunteering for maintainership of this port, since I use notmuch daily
> and regularly follow the mailing lists.
>
> Please let me know if it lives up the ports standards, i want to learn
> to create good ports.

Tweaked tar attached;

- follow closer to standard Makefile ordering

- avoid hardcoding python version numbers as much as possible; it's not
going to be super-clean building with both py2 and py3 in the one port
but at least we can make it so the switch from 3.6 to 3.7 doesn't break
things

- don't hide build commands

- use standard naming for python bindings

- xapian is a LIB_DEPENDS not BUILD/RUN_DEPENDS

- we have cp -a now, drop patch

- we have python2/python3 in the path now, drop patch

- fix WANTLIB

Still needs doing: SHARED_LIBS needs fixing to be under ports control
(see comments next to SHARED_LIBS). We need to be able to bump these
from the port if necessary.

Maybe also: drop the quite intrusive man gz patches and just run
gunzip in post-install, it's a bit less efficient at build time, but
avoids some pain for updates.