Thanks for your advice! I confirmed that old zathura still works with
updated girara, so no major bump is needed.
On Mon, Mar 04, 2019 at 02:31:17AM +0100, Jeremie Courreges-Anglas wrote:
>
> Technically some exported symbols have been removed, so it would be
> a major bump. But said symbols aren't exported any more because
> meson.build now uses "gnu_symbol_visibility: 'hidden'" to build the
> library. Feel free to skip the major bump if you know that zathura
> linked against girara-0.3.0 works fine when using the library from
> girara-0.3.2.
>
> BTW there is a nice tool to check changes in exported symbols:
> /usr/src/lib/check_sym
>
> Apart from the major bump concern, I have noticed the following points
> that could be improved:
> - HOMEPAGE / MASTER_SITES could switch to https
> - WANTLIB should be refreshed (make port-lib-depeends-check)
> - libnotify is not picked up by default any more, is should either be
> explicitely activated or removed from LIB_DEPENDS
- I switched to https, but cannot test it as the server is experiencing
turbulence at the moment.
- I updated WANTLIB following the recommendation of make
port-lib-depends-check
- the developers decided to disable libnotify by default, so I removed
the dependency
> This makes your diff hard to apply. If you can't use cvs diff, please
> at least do something like:
>
> cd /build/usr/ports/x11/girara/ && diff -uNprx CVS /usr/ports/x11/girara .
>
> so that we don't have to guess the pathname strip count.
I would prefer to use cvs diff, but the resulting diff does not include
new and deleted files (perhaps there is an option that I missed?).
diff -uNprx CVS /usr/ports/x11/girara/Makefile ./Makefile
--- /usr/ports/x11/girara/Makefile Wed Sep 19 11:35:19 2018
+++ ./Makefile Mon Mar 4 09:21:13 2019
@@ -1,27 +1,26 @@
# $OpenBSD: Makefile,v 1.17 2018/09/19 09:35:19 landry Exp $
COMMENT = user interface library from pwmt
-DISTNAME = girara-0.3.0
+DISTNAME = girara-0.3.2
SHARED_LIBS += girara-gtk3 1.0 # 3.1
EXTRACT_SUFX = .tar.xz
CATEGORIES = x11
-HOMEPAGE = http://pwmt.org/projects/girara/
+HOMEPAGE = https://pwmt.org/projects/girara/
# zlib
PERMIT_PACKAGE_CDROM =Yes
-WANTLIB += gdk-3 gio-2.0 glib-2.0 gobject-2.0 gtk-3 intl json-c
-WANTLIB += notify pango-1.0
+WANTLIB += atk-1.0 cairo cairo-gobject gdk-3 gdk_pixbuf-2.0 gio-2.0 glib-2.0
+WANTLIB += gobject-2.0 gtk-3 intl json-c m pango-1.0 pangocairo-1.0
-MASTER_SITES = http://pwmt.org/projects/girara/download/
+MASTER_SITES = https://pwmt.org/projects/girara/download/
MODULES = devel/meson
BUILD_DEPENDS = devel/gettext-tools
LIB_DEPENDS = x11/gtk+3 \
- devel/json-c \
- devel/libnotify
+ devel/json-c
# c11
COMPILER = base-clang ports-gcc
diff -uNprx CVS /usr/ports/x11/girara/distinfo ./distinfo
--- /usr/ports/x11/girara/distinfo Wed Sep 19 11:35:19 2018
+++ ./distinfo Mon Mar 4 08:56:33 2019
@@ -1,2 +1,2 @@
-SHA256 (girara-0.3.0.tar.xz) = t1L6X/CpjPp3O7z2a7il4zemHLsIXWV3s5eReNF+QaI=
-SIZE (girara-0.3.0.tar.xz) = 57820
+SHA256 (girara-0.3.2.tar.xz) = FwA1OhAfPFIPmyLnnXHqWyaKnsMkeWz55kd12Wuwhs0=
+SIZE (girara-0.3.2.tar.xz) = 58220
diff -uNprx CVS /usr/ports/x11/girara/patches/patch-tests_meson_build ./patches/patch-tests_meson_build
--- /usr/ports/x11/girara/patches/patch-tests_meson_build Wed Sep 19 11:35:19 2018
+++ ./patches/patch-tests_meson_build Thu Jan 1 01:00:00 1970
@@ -1,16 +0,0 @@
-$OpenBSD: patch-tests_meson_build,v 1.2 2018/09/19 09:35:19 landry Exp $
-
-env -u (for unset) doesnt exist on OpenBSD
-
-Index: tests/meson.build
---- tests/meson.build.orig
-+++ tests/meson.build
-@@ -44,7 +44,7 @@ if check.found()
- env.set('XDG_TEST_HELPER_PATH', meson.current_build_dir())
-
- test('tests-without-home', env_bin,
-- args: ['-u', 'HOME', tests],
-+ args: ['HOME', tests],
- env: env,
- timeout: 60*60,
- is_parallel: false
No comments:
Post a Comment