Sunday, April 28, 2019

Re: NEW: devel/qtav

On Thu Apr 25, 2019 at 12:00:19AM +0200, Klemens Nanni wrote:
> On Sun, Apr 14, 2019 at 07:25:40PM +0200, Rafael Sadowski wrote:
> > here's a new port for QtAV which can be used by the upcoming digikam
> > 6.0.0 update. It's more or less a Qt5 QML FFmpeg player. This port is
> > based on work from Vadim. After our FFmpeg update it's work quit well
> > and fast. Test with the installed player and with digikam6.
> devel is overloaded already, this port should go to multimedia I think.

Done.

>
> With PKGNAME=${DISTNAME:L} you can ditch having V next to GH_TAGNAME and
> the reason for explicit PKGNAME becomes clearer, but that's just a
> nit-picky suggestion.

Done.


>
> The majority of patches seem trivial to upstream, do you have plans to
> do so?
>
> Installed docs are broken, warnings during `make package':
>
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/Player/../../Changelog
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/Player/changelog
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/Player/../../README.md
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/Player/README
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAV/../../Changelog
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAV/changelog
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAV/../../README.md
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAV/README
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAVWidgets/../../Changelog
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAVWidgets/changelog
> Warning: symlink(s) point to non-existent /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAVWidgets/../../README.md
> /usr/ports/pobj/qtav-1.12.0/fake-amd64/usr/local/share/doc/QtAVWidgets/README
>

Fixed.

> > Comment:
> > FFmpeg-based Qt multimedia framework
> >
> > Description:
> > QtAV is a multimedia playback library based on Qt and FFmpeg.
> That is a bit scarse and pretty much equals COMMENT; this package ships
> a full blown player (although not in $PATH), so at least that should be
> made clear.

I think it's obsolete. Please read below.

>
> > WWW: http://www.qtav.org/
> Has TLS.

Done.
>
> Libs are LGPLv2.1 *or later*.

Done.

>
> Tested successfully with the player on amd64. Preview images when
> hovering over the time line are shown, but in their own X window which
> messes with tiling window managers (or at least dwm in my case) as the
> image is shows up anywhere but next to the cursor. No biggy and
> probably rather a application agnostic WM problem, but worth noting.
>

I like the following approach to FreeBSD:

# The examples are GLPv3 licencensed and have too generic names, like 'Player',
# so don't install them.
MODQMAKE_ARGS += CONFIG+=no-examples

Qtav is used only as library.

New tarball attached. Thanks for the input.

RS

No comments:

Post a Comment