Re: vulkan ports

Please find my comments below. Please keep in mind that this is not for
pre 6.5.

On Mon Mar 25, 2019 at 05:07:32PM +1100, Jonathan Gray wrote:
> To support the Vulkan graphics API there are multiple ports needed.
> These are Apache 2.0 licensed with a cmake build system and build time
> deps on python in some cases so it would be painful to add to xenocara.
>
> glslang-7.11.3113 reference front-end for GLSL and ESSL

Looks good for me.

> spirv-headers-1.3.7 SPIRV-Headers

- NO_TEST = Yes
- Move MODULES under WANTLIB


$ portcheck
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: include/spirv/1.0/spirv.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: include/spirv/1.1/spirv.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: include/spirv/1.2/spirv.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: include/spirv/unified1/spirv.py

> spirv-tools-2019.2 API and commands for processing SPIR-V

- Remove ":String" in CONFIGURE_ARGS please.

> vulkan-headers-1.1.101.0 Vulkan header files

$ portcheck
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: share/vulkan/registry/cgenerator.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: share/vulkan/registry/generator.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: share/vulkan/registry/genvk.py
Python module without compiled version, consider using ${MODPY_BIN}
${MODPY_LIBDIR}/compileall.py: share/vulkan/registry/reg.py

- NO_TEST = Yes

> vulkan-loader-1.1.101.0 Vulkan ICD loader

Looks good for me.

> vulkan-tools-1.1.101.0 Vulkan Utilities and Tools

- NO_TEST = Yes
- Remove ":Bool" in CONFIGURE_ARGS please.
- Move MODULES under WANTLIB

> vulkan-validation-layers-1.1.101.0 Vulkan Validation Layers

- NO_TEST = Yes
- Remove ":Bool" in CONFIGURE_ARGS please.
- Move MODULES under WANTLIB

>
> These are all in graphics/* for now but most of these could also go in
> devel/.
>
> While these will build, to use the result requires a drm with support
> for render nodes. The in tree drm lacks this, a pending update
> supports them.
>
> In terms of drivers/ICDs implemented by Mesa some patches are required
> to provide non-linux codepaths and recent hardware is required.
> The Mesa Vulkan drivers are not currently built or installed.
>
> For ATI/AMD hardware only amdgpu is supported not radeondrm(4).
>
> For Intel hardware ivy bridge and up is supported by Mesa, but the Intel
> Vulkan code in Mesa 18.3 requires userptr in drm which we don't
> implement. As of Mesa 19.0 userptr is no longer required.
>
> With a linux 4.19 based inteldrm(4), patched Mesa 19.0, and the attached
> ports vkcube/vulkaninfo from vulkan-tools run as does vkQuake
> (https://github.com/Novum/vkQuake).