My main concern here is that I think this should have a MAINTAINER.
jsg@, you didn't add yourself, so I interpret this as that you would
prefer these ports be maintained by someone else? I am offering to be
MAINTAINER, but if someone with more experience with the lower-level
aspects of GPUs/Vulkan is ready to step up, I would gladly leave it to
that developer. There are regular updates to these ports on GitHub, and
IMO the future maintainer should work on upstreaming the patches.
Otherwise it works fine here - tested also with vulkaninfo, vkcube, and
vkQuake (I have a port for the latter ready for once
graphics/vulkan-loader is in the tree). Graphics hardware is a Vega 64
running amdgpu.
I've attached an updated tarball, updated to latest releases (sdk
releases in the case of the vulkan-* ports), me as proposed maintainer,
the adjusted license comments for glslang and spirv-headers, and some
style nits applied (space before '=', order of Makefile entries same as
Makefile.template).
Some comments with context below.
Comments? ok?
On Mon, Mar 25, 2019 at 05:07:32PM +1100, Jonathan Gray wrote:
> To support the Vulkan graphics API there are multiple ports needed.
> These are Apache 2.0 licensed [...]
Per the GitHub repo, glslang uses a 3-clause BSD license plus a custom,
but free NVIDIA license (see
https://github.com/KhronosGroup/glslang/blob/master/LICENSE.txt) for
the preprocessor. spirv-headers has a BSD-style license with the only
clause being to retain the copyright notice and permission, as well as
something like a "warning" that file modification may no longer reflect
"Khronos standards".
> These are all in graphics/* for now but most of these could also go in
> devel/.
My gut says graphics/ because it fits and devel/ is crowded.
No comments:
Post a Comment