On 2019/06/11 00:12, Kurt Mosiejczuk wrote:
> On Tue, Jun 11, 2019 at 03:28:32AM +0000, wen heping wrote:
> > Hi, ports@:
>
> > Here is a patch to update devel/py-tz to 2019.1, it build and test well
> > on my amd64 system, with both python2 and python3 flavors.
> > Many ports depends on pytz, I have tested some of it, include:
> > astro/py-astral
> > math/py-numpy
> > devel/py-babel
> > devel/py-tzlocal
> > The patch does not cause run error or new tests fail.
>
> > Comments? OK ?
>
> > HOMEPAGE = http://pytz.sourceforge.net/
>
> There's a new homepage linked from its pypi page. It's also https. It
> should be switched to that.
>
> The PERMIT_PACKAGE_CDROM should get switched to the new PERMIT_PACKAGE
> also.
>
> That list of consumers is a lot smaller than the full list. I'd usually
> try and at least get a greater percentage of the TEST_DEPENDS consumers.
> Perhaps at least py-django/stable and py-django/lts since you were just
> also working with those?
>
> With the updated HOMEPAGE and some more testing, I think this looks good.
> But I'd really like tests on more than 4 of 20 TEST_DEPENDS consumers.
>
> --Kurt
>
Often py-tz updates are just updating the tzdata files and dep testing
isn't really needed, though I think this time a bit more testing than usual
probably is warranted as there's a new error condition
+ if zone is None:
+ raise UnknownTimeZoneError(None)
No comments:
Post a Comment