On Sat, 29 Jun 2019 13:51:34 -0400, Kurt Mosiejczuk <kurt@cranky.work>
wrote:
> On Sat, Jun 29, 2019 at 01:26:16PM -0400, Daniel Jakots wrote:
> > On Sat, 29 Jun 2019 13:10:12 -0400, Kurt Mosiejczuk
> > <kurt@cranky.work> wrote:
>
> > > I was testing the new TEST_IS_INTERACTIVE=network stuff and
> > > figured www/py-requests would be ideal for that. However, the
> > > tests were broken. I looked into it and they are broken for
> > > pytest >=4
>
> > > Upstream has done a commit with a patch that fixes it, but it
> > > hasn't been in a release yet, so I added the patch manually. Once
> > > this patch is applied, the tests run as they should.
>
> > Can you link the commit please?
>
> Yes. Didn't think of that.
> https://github.com/kennethreitz/requests/pull/5049/commits/dc75b3ca0b4c95648eb07b92cb414394d99c13a0
Oh it's not committed (yet) upstream.
Add the link https://github.com/kennethreitz/requests/pull/5049 in the
patch header (so I can easily find it during next update) and with that
ok danj@
Cheers,
Daniel
No comments:
Post a Comment