On Sat, Jun 22, 2019 at 12:27:30PM +0200, Sebastien Marie wrote:
> - the port version is "2.1pl0" : the official 2.1 (from Jul 26, 2017)
> doesn't build against LLVM 7. There are commits in master branch to
> support it, so I targeted the latest commit in master branch (Mar 26, 2019).
OK, perhaps "# supports LLVM 7" above GH_COMMIT then?
> it is an example... you could use it on something else than the kernel.
Sure, just a nit really - i'll leave that to you.
> I suggested chmod with *-R*. The tarball (in my mail) has wrong mode for
> PORTS_PRIVSEP: _pbuild can't read the ports tree.
Pardon me; with `-R' all is fine.
> FIX_EXTRACT_PERMISSIONS is for fixing the upstream tarball. here it is fine.
Yes, just tried it blindly before looking into it.
Another thing: we usually do not install docs under versioned paths,
could you fix that by using GH_PROJECT instead? With that, I think V
is obsolete as SUSBT_VARS does not use it anymore, so it can go into
DISTNAME directly. With the transition to the next GitHub release, it
would go into GH_TAGNAME directly, so no reuse of V here either.
No comments:
Post a Comment