On Sun, Jun 30, 2019 at 12:46:42AM +0200, Jeremie Courreges-Anglas wrote:
> "[recommonmark] allows you to write CommonMark inside of Docutils &
> Sphinx projects."
> It is needed to generate the documentation in llvm-8.0.0.
> The patches are there because recent versions of textproc/py-commonmark
> rename the module. I'd rather import py-recommonmark as is, with
> appropriate comments (in textproc/py-commonmark, maybe?) than deal with
> updating textproc/py-commonmark now and testing www/puppetboard.
> cc'ing sebastia@
> I'm looking for reviews and oks to import.
I assumed at first maybe you used the GH_* rather than PyPI to include
all the tests, but the tests don't work completely from Github
either. What's the reason to use GH_* rather than just MODPY_PI?
Also, there is no need to include TEST_DEPENDS=${RUN_DEPENDS},
lang/python does that automatically since the end of the hackathon.
I can't get all the tests to work. There are complaints about missing
files in different subdirectories under tests/
That may not matter, I suppose, but it doesn't give me the warm fuzzies.
Also, do you wish to have the package named recommonmark-0.5.0 or
py-recommonmark-0.5.0? Right now it is the former since there isn't a
PKGNAME line.
--Kurt
No comments:
Post a Comment