Wednesday, June 26, 2019

Re: (new version) Re: NEW PORT: aspect-crop

On Wed, Jun 26, 2019 at 01:36:40PM +0200, Klemens Nanni wrote:
> With std=c++17 set, shouldn't you set COMPILER as well?
>
> DESCR has trailing spaces and the Makefile could use space vs. tabs
> cleaning around the assignment operator, looks good otherwise.

Oh, the C++17 requirement is actually gone now, I forgot to scrape it from
the makefile as well.

But no, since qt5 already does it for me.
Default being MODQT5_USE_CXX11=yes, which does take care of it for me.

Hint for you: always use make show=...
don't trust the Makefile to be the ONLY source of variables.
Modules may surprise you.

No comments:

Post a Comment