Re: [update] devel/flake8 (and dependencies)

On Thu, Jun 20, 2019 at 10:08:07AM +0200, Paco Esteban wrote:

> Here's an update for devel/flake8 from 3.5.0 to 3.7.7.
> The version now in ports always throws an error (it's py-codestyle's
> fault, but that upgrade makes flake8 not to work ...) and pollutes the
> results (like vim quickfix list for instance). You can see it here:

> https://github.com/PyCQA/pycodestyle/issues/728

> There are quite a few changes between those 2 versions, you can see them
> here:

> http://flake8.pycqa.org/en/latest/release-notes/index.html#x-release-series

> I had to update some dependencies too:

> devel/pyflakes 1.5.0 --> 2.1.1
> https://github.com/PyCQA/pyflakes/blob/master/NEWS.rst
> devel/py-entrypoints 0.2.3 --> 0.3
> devel/py-codestyle 2.3.1 --> 2.5.0
> https://github.com/PyCQA/pycodestyle/blob/master/CHANGES.txt

> All pass tests and install correctly (py3 on amd64).

The ones with python 2 tests also pass.


> Some of them have an insane amount of dependencies just to run tests, so
> I would appreciate guidance on how to do this properly. Should I test +
> install all of them ?

It helps be sure one didn't break anything in my experience. I usually just
run the tests which will install the test dependencies and then run tests.
"pkg_delete -a" is your friends after rounds of tests like that. It deletes
things that were installed automatically but aren't needed now.

> dependent on devel/flake8 (all of them TEST_DEPENDS):
> www/youtube-dl
> it took hours ...
> Ran 2386 tests in 18354.702s
> FAILED (errors=826, failures=322)
> sysutils/ranger
> Test crashes with: https://onna.be/paste/ranger_crash.txt
> net/py-libcloud
> 2 failed, 9165 passed, 19 skipped, 534 warnings
> seems related to paramikossh ??

This is fine. I re-ran these tests (both py and py3) and they all passed.

> textproc/py-commonmark
> test fails with
> ModuleNotFoundError: No module named 'CommonMark'

There's two diffs on the list about making this work. jca's diff is the
better one. :) All tests pass after applying one of the patches.

> dependent on devel/pyflakes:
> security/py-yaswfp
> all tests pass
> devel/spyder/spyder
> did not check
>
> dependent on devel/py-entrypoints:
> devel/py-nbconvert
> did not check

Tests pass for me for both flavors.

> dependent on devel/py-codestyle:
> games/freeorion
> did not check
> sysutil/d-feet
> did not check
> www/urlmatch
> all tests pass

The only thing I'd change on these diffs is make sure to convert the
PERMIT_PACKAGE_CDROM lines to PERMIT_PACKAGE lines while we're doing
the updates.

With that tweak. OK kmos@

Thanks for the nice work on these updates.

--Kurt