Re: UPDATE: security/keepassxc

On Sun Jun 02, 2019 at 05:41:37PM +0200, Jeremie Courreges-Anglas wrote:
> On Sun, Jun 02 2019, Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> > Update keepassxc to 2.4.2
> >
> > CHANGELOG:
> > https://github.com/keepassxreboot/keepassxc/releases/tag/2.4.2
> >
> > I send the Alloc class patch upsteream as usual. Tests and feedback
> > welcome.
>
> I didn't check anything else, but the Alloc class patch shouldn't be
> sent upstream as-is, IMO. Please see below.
>
> > RS
> >
> > ===================================================================
> > RCS file: patches/patch-src_core_Alloc_cpp
> > diff -N patches/patch-src_core_Alloc_cpp
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++ patches/patch-src_core_Alloc_cpp 2 Jun 2019 09:44:06 -0000
> > @@ -0,0 +1,23 @@
> > +$OpenBSD$
> > +
> > +Index: src/core/Alloc.cpp
> > +--- src/core/Alloc.cpp.orig
> > ++++ src/core/Alloc.cpp
> > +@@ -20,6 +20,8 @@
> > + #include <sodium.h>
> > + #ifdef Q_OS_MACOS
> > + #include <malloc/malloc.h>
> > ++#elif defined(Q_OS_OPENBSD)
> > ++#include <stdlib.h>
> > + #else
> > + #include <malloc.h>
> > +