Re: vulkan ports

On Wed, Jun 19, 2019 at 12:26:05AM -0600, Thomas Frohwein wrote:
> On Wed, Jun 19, 2019 at 03:15:15PM +1000, Jonathan Gray wrote:
> [...]
> > This collection of ports no longer seems to work on inteldrm with ivy bridge.
> >
> > spirv-headers-1.4.1 SPIRV-Headers
> > spirv-tools-2019.3 API and commands for processing SPIR-V
> > vulkan-headers-1.1.108.0 Vulkan header files
> > vulkan-loader-1.1.108.0 Vulkan ICD loader
> > vulkan-tools-1.1.108.0 Vulkan Utilities and Tools
> > vulkan-validation-layers-1.1.108.0 Vulkan Validation Layers
>
> I hit an abort trap with coredump on both Skylake and Vega 64 (the
> latter w/ amdgpu). I don't recall an issue with vulkaninfo with sdk
> version 1.1.104. vkcube still runs fine on both. Will take a deeper dive
> to see what's going on with vulkaninfo that I missed...

I see the same problem described here on broadwell, vkcube also runs.
Linux seems to be more forgiving of getting pthreads wrong.

Perhaps we revert
https://github.com/KhronosGroup/Vulkan-Loader/commit/ecb0b1e69fb2f4d3cae262e6da24c170ce62ae13 ?

commit ecb0b1e69fb2f4d3cae262e6da24c170ce62ae13 (tag: sdk-1.1.108.0, origin/sdk-1.1.108, origin/master, origin/HEAD)
Author: baldurk <baldurk@baldurk.org>
Date: Mon Jun 10 13:07:40 2019 +0100

loader: Call through layers for device extensions

If we reach the terminator function then we look up json properties
per-layer there. This allows layers to participate in the
enumeration and filter the list of extensions before they reach the
application.

Layers: count = 7
=======
VK_LAYER_GOOGLE_threading (Google Validation Layer) Vulkan version 1.1.108, layer version 1
Layer Extensions count = 1
VK_EXT_debug_report : extension revision 6
Devices count = 1
GPU id : 0 (Intel(R) HD Graphics 5500 (Broadwell GT2))

Program received signal SIGABRT, Aborted.
thrkill () at -:3
3 -: No such file or directory.
in -
Current language: auto; currently asm
(gdb) bt
#0 thrkill () at -:3
#1 0x0000014f753231fe in _libc_abort () at /usr/src/lib/libc/stdlib/abort.c:51
#2 0x0000014f75309812 in _libc_pthread_mutex_unlock (mutexp=0x150132a1a80)
at /usr/src/lib/libc/thread/rthread_mutex.c:265
#3 0x000001501a9d25f0 in vkEnumerateDeviceExtensionProperties () from /usr/local/lib/libvulkan.so.0.0
#4 0x0000014d51e7a4ca in AppGetPhysicalDeviceLayerExtensions () from /usr/local/bin/vulkaninfo
#5 0x0000014d51e7692d in main () from /usr/local/bin/vulkaninfo

>
> ==========
> VULKANINFO
> ==========
>
> Vulkan Instance Version: 1.1.108
>
>
>
> Instance Extensions:
> ====================
> Instance Extensions count = 16
> VK_EXT_acquire_xlib_display : extension revision 1
> VK_EXT_debug_report : extension revision 8
> VK_EXT_debug_utils : extension revision 1
> VK_EXT_direct_mode_display : extension revision 1
> VK_EXT_display_surface_counter : extension revision 1
> VK_KHR_device_group_creation : extension revision 1
> VK_KHR_display : extension revision 23
> VK_KHR_external_fence_capabilities : extension revision 1
> VK_KHR_external_memory_capabilities : extension revision 1
> VK_KHR_external_semaphore_capabilities: extension revision 1
> VK_KHR_get_display_properties2 : extension revision 1
> VK_KHR_get_physical_device_properties2: extension revision 1
> VK_KHR_get_surface_capabilities2 : extension revision 1
> VK_KHR_surface : extension revision 25
> VK_KHR_xcb_surface : extension revision 6
> VK_KHR_xlib_surface : extension revision 6
> Layers: count = 7
> =======
> VK_LAYER_GOOGLE_threading (Google Validation Layer) Vulkan version 1.1.108, layer version 1
> Layer Extensions count = 1
> VK_EXT_debug_report : extension revision 6
> Abort trap (core dumped)
>
> Core was generated by `vulkaninfo'.
> Program terminated with signal SIGABRT, Aborted.
> #0 thrkill () at -:3
> 3 -: No such file or directory.
> (gdb) bt full
> #0 thrkill () at -:3
> No locals.
> #1 0x000007756ecdc73e in _libc_abort () at /usr/src/lib/libc/stdlib/abort.c:51
> mask = 4294967263
> sa = <optimized out>
> #2 0x000007756ed4edb2 in _libc_pthread_mutex_unlock (mutexp=<optimized out>)
> at /usr/src/lib/libc/thread/rthread_mutex.c:265
> mutex = 0x7758fdf8c60
> self = 0x7756ed58450 <_initial_thread>
> #3 0x000007753992d5f0 in vkEnumerateDeviceExtensionProperties ()
> from /usr/local/lib/libvulkan.so.0.0
> No symbol table info available.
> #4 0x000007732ab774ca in AppGetPhysicalDeviceLayerExtensions ()
> No symbol table info available.
> #5 0x000007732ab7392d in main ()
> No symbol table info available.
> (gdb)
>
> >
> > $ vulkaninfo
> > ==========
> > VULKANINFO
> > ==========
> >
> > Vulkan Instance Version: 1.1.108
> >
> > INTEL-MESA: warning: Ivy Bridge Vulkan support is incomplete
> > INTEL-MESA: warning: vulkan/anv_device.c:1269: FINISHME: Implement pop-free point clipping
> > /usr/ports/pobj/vulkan-tools-1.1.108.0/Vulkan-Tools-sdk-1.1.108.0/vulkaninfo/vulkaninfo.c:1128: failed with VK_ERROR_TOO_MANY_OBJECTS
> >
> > $ vkcube
> > INTEL-MESA: warning: Ivy Bridge Vulkan support is incomplete
> > Segmentation fault (core dumped)
> >
> > Core was generated by `vkcube'.
> > Program terminated with signal SIGSEGV, Segmentation fault.
> > #0 0x00000c04bed7225d in vkGetDeviceProcAddr () from /usr/local/lib/libvulkan.so.0.0
> > (gdb) bt
> > #0 0x00000c04bed7225d in vkGetDeviceProcAddr () from /usr/local/lib/libvulkan.so.0.0
> > #1 0x00000c0203e67a19 in main ()
> >
> > Same thing with
> >
> > spirv-headers-1.4.1 SPIRV-Headers
> > spirv-tools-2019.3 API and commands for processing SPIR-V
> > vulkan-headers-1.1.106.0 Vulkan header files
> > vulkan-loader-1.1.106.0 Vulkan ICD loader
> > vulkan-tools-1.1.106.0 Vulkan Utilities and Tools
> >
> > I thought it worked with 1.1.101 but it seems largely the same though
> > vulkaninfo has a bit more output with the same error.
> >
> > I'll check 1.1.108 on broadwell later.
> >
> > spirv-headers-1.3.7 SPIRV-Headers
> > spirv-tools-2019.2 API and commands for processing SPIR-V
> > vulkan-headers-1.1.101.0 Vulkan header files
> > vulkan-loader-1.1.101.0 Vulkan ICD loader
> > vulkan-tools-1.1.101.0 Vulkan Utilities and Tools
> > vulkan-validation-layers-1.1.101.0 Vulkan Validation Layers
> >
> > $ vkcube
> > INTEL-MESA: warning: Ivy Bridge Vulkan support is incomplete
> > Segmentation fault (core dumped)
> >
> > $ vulkaninfo
> > INTEL-MESA: warning: Ivy Bridge Vulkan support is incomplete
> > INTEL-MESA: warning: vulkan/anv_device.c:1269: FINISHME: Implement pop-free point clipping
> > ==========
> > VULKANINFO
> > ==========
> >
> > Vulkan Instance Version: 1.1.101
> >
> >
> >
> > Instance Extensions:
> > ====================
> > Instance Extensions count = 16
> > VK_EXT_acquire_xlib_display : extension revision 1
> > VK_EXT_debug_report : extension revision 8
> > VK_EXT_debug_utils : extension revision 1
> > VK_EXT_direct_mode_display : extension revision 1
> > VK_EXT_display_surface_counter : extension revision 1
> > VK_KHR_device_group_creation : extension revision 1
> > VK_KHR_display : extension revision 23
> > VK_KHR_external_fence_capabilities : extension revision 1
> > VK_KHR_external_memory_capabilities : extension revision 1
> > VK_KHR_external_semaphore_capabilities: extension revision 1
> > VK_KHR_get_display_properties2 : extension revision 1
> > VK_KHR_get_physical_device_properties2: extension revision 1
> > VK_KHR_get_surface_capabilities2 : extension revision 1
> > VK_KHR_surface : extension revision 25
> > VK_KHR_xcb_surface : extension revision 6
> > VK_KHR_xlib_surface : extension revision 6
> > Layers: count = 6
> > =======
> > VK_LAYER_GOOGLE_threading (Google Validation Layer) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 1
> > VK_EXT_debug_report : extension revision 6
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 0
> >
> > VK_LAYER_GOOGLE_unique_objects (Google Validation Layer) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 0
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 0
> >
> > VK_LAYER_LUNARG_core_validation (LunarG Validation Layer) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 1
> > VK_EXT_debug_report : extension revision 6
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 2
> > VK_EXT_debug_marker : extension revision 4
> > VK_EXT_validation_cache : extension revision 1
> >
> > VK_LAYER_LUNARG_object_tracker (LunarG Validation Layer) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 1
> > VK_EXT_debug_report : extension revision 6
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 1
> > VK_EXT_debug_marker : extension revision 4
> >
> > VK_LAYER_LUNARG_parameter_validation (LunarG Validation Layer) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 1
> > VK_EXT_debug_report : extension revision 6
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 1
> > VK_EXT_debug_marker : extension revision 4
> >
> > VK_LAYER_LUNARG_standard_validation (LunarG Standard Validation) Vulkan version 1.1.101, layer version 1
> > Layer Extensions count = 1
> > VK_EXT_debug_report : extension revision 6
> > Devices count = 1
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Layer-Device Extensions count = 2
> > VK_EXT_debug_marker : extension revision 4
> > VK_EXT_validation_cache : extension revision 1
> >
> > Presentable Surfaces:
> > =====================
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Surface type : VK_KHR_xcb_surface
> > Formats: count = 2
> > B8G8R8A8_SRGB
> > B8G8R8A8_UNORM
> > Present Modes: count = 3
> > IMMEDIATE_KHR
> > MAILBOX_KHR
> > FIFO_KHR
> > VkSurfaceCapabilitiesKHR:
> > minImageCount = 2
> > maxImageCount = 0
> > currentExtent:
> > width = 256
> > height = 256
> > minImageExtent:
> > width = 256
> > height = 256
> > maxImageExtent:
> > width = 256
> > height = 256
> > maxImageArrayLayers = 1
> > supportedTransform:
> > VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
> > currentTransform:
> > VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
> > supportedCompositeAlpha:
> > VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR
> > VK_COMPOSITE_ALPHA_INHERIT_BIT_KHR
> > supportedUsageFlags:
> > VK_IMAGE_USAGE_TRANSFER_SRC_BIT
> > VK_IMAGE_USAGE_TRANSFER_DST_BIT
> > VK_IMAGE_USAGE_SAMPLED_BIT
> > VK_IMAGE_USAGE_STORAGE_BIT
> > VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
> > VkSurfaceCapabilities2EXT:
> > supportedSurfaceCounters:
> > None
> >
> > GPU id : 0 (Intel(R) Ivybridge Mobile)
> > Surface type : VK_KHR_xlib_surface
> > Formats: count = 2
> > B8G8R8A8_SRGB
> > B8G8R8A8_UNORM
> > Present Modes: count = 3
> > IMMEDIATE_KHR
> > MAILBOX_KHR
> > FIFO_KHR
> > /usr/ports/pobj/vulkan-tools-1.1.101.0/Vulkan-Tools-sdk-1.1.101.0/vulkaninfo/vulkaninfo.c:4847: failed with VK_ERROR_TOO_MANY_OBJECTS
> > VkSurfaceCapabilitiesKHR:
> > minImageCount = 2
> > maxImageCount = 0
> > currentExtent:
> > width = 256
> > height = 256
> > minImageExtent:
> > width = 256
> > height = 256
> > maxImageExtent:
> > width = 256
> > height = 256
> > maxImageArrayLayers = 1
> > supportedTransform:
> > VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
> > currentTransform:
> > VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR
> > supportedCompositeAlpha:
> > VK_COMPOSITE_ALPHA_OPAQUE_BIT_KHR
> > VK_COMPOSITE_ALPHA_INHERIT_BIT_KHR
> > supportedUsageFlags:
> > VK_IMAGE_USAGE_TRANSFER_SRC_BIT
> > VK_IMAGE_USAGE_TRANSFER_DST_BIT
> > VK_IMAGE_USAGE_SAMPLED_BIT
> > VK_IMAGE_USAGE_STORAGE_BIT
> > VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT
> > VkSurfaceCapabilities2EXT:
> > supportedSurfaceCounters:
> > None
> >
> >
> > Groups :
> > ========
> > Device Group Properties (Group 0) :
> > physicalDeviceCount = 1
> >
> > Intel(R) Ivybridge Mobile (ID: 0)
> >
> > subsetAllocation = 0
>