Re: net/quassel port

Hi,

On Wed, Jul 03, 2019 at 09:37:11PM +0000, ornx wrote:
> I noticed that the Quassel IRC client was not in the ports collection, so I thought I would take the port previously written by Chuck Burns (https://marc.info/?l=openbsd-ports&m=140875982720994&w=2) and update it to the latest version, as well as make some modifications. Quassel is a distributed IRC client, which means that it is split into a daemon (quasselcore) which handles the actual IRC connection, stores logs, etc, as well as a graphical client (quasselclient) which connects to the daemon and downloads the logs and handles input from the user. There is also a "monolithic" client, which combines these two parts to form a typical IRC client so that you don't need to fiddle with configuring a daemon in order to use the program.
> The previously posted version of this port used MULTI_PACKAGES, but since QT version 5 no longer seems to be split up into various libraries in OpenBSD, all three programs now share the same dependencies (x11/qt5/qtbase and x11/qt5/qtscript, as well as cmake). Therefore, I have removed the MULTI_PACKAGES feature and changed it so it always just installs all three programs (quasselcore, quasselclient, and the monolithic client). I also made some minor changes to the rc script.
> This is my first OpenBSD port, so I'm sure I've probably done at least something wrong, so I welcome any feedback or criticism.

You may want to look at my WIP Quassel port which is in openbsd-wip:
https://github.com/jasperla/openbsd-wip/blob/master/net/quassel/Makefile

There are a few differences between your port and my port which you can
consider.

If I were you I would look at the CONFIGURE_ARGS that my port is using.
For instance, I explicitely enabled WITH_KDE. I believe it provides
better integration with some desktop environments. The downside is that
it pulls in quite some dependencies.

Additionally, I explicitely disabled WebEngine and WebKit support.
I can't remember why I passed -DGIT_EXECUTABLE="" but it probably
doesn't hurt to add that.

My port uses the multimedia/phonon MODULE whereas yours does not. But
that may be a result of enabling WITH_KDE.

Thanks,
Caspar Schutijser