I need to do some testing, this is a critical port for me and notes like
"This included a fairly substantial rewrite of the relevant code, so
please report any new bugs related to adding pages" mean I definitely
need to check it.
(btw, wen: when you send an update for a port, please include details
about what has changed in it, e.g. an excerpt from the changelog, it
makes it easier for reviewers.)
On 2019/07/01 12:09, Charlene Wendling wrote:
> Hi,
>
> On Mon, 1 Jul 2019 03:30:38 +0000
> wen heping wrote:
>
> > Hi,
> >
> > Here is a patch to update textproc/p5-PDF-API2 to 2.034. It build
> > well and passed all test on my amd64 system.
> >
> > Two ports depends on it, textproc/p5-PDF-API2-Simple and
> > textproc/p5-PDF-Table. Both build well and passed all tests.
> >
> > Comments? OK?
>
> It lacks Test::Exception as a TEST_DEPENDS. We could enable author
> testing since we have all it needs in ports, but it's your call
> Stuart.
>
> Here is a modified diff.
>
> OK cwen@ with this.
diff looks good, I'll let you know when I've been able to get it tested.
(I don't think there's any need for author testing as we aren't the author.)
No comments:
Post a Comment