Re: [update] py-sip 4.19.17

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/py-sip/Makefile,v
retrieving revision 1.42
diff -u -r1.42 Makefile
--- Makefile 28 Apr 2019 20:51:37 -0000 1.42
+++ Makefile 26 Jun 2019 16:05:19 -0000
@@ -5,9 +5,9 @@
# XXX Be particularly careful when testing updates.
# API breaks often.

-DISTNAME= sip-4.19.3
+MODPY_EGG_VERSION = 4.19.17
+DISTNAME= sip-${MODPY_EGG_VERSION}
PKGNAME= py-${DISTNAME}
-REVISION = 4
CATEGORIES= devel

HOMEPAGE= http://www.riverbankcomputing.co.uk/software/sip/intro
@@ -19,7 +19,7 @@

COMPILER = base-clang ports-gcc base-gcc

-MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=pyqt/}
+MASTER_SITES= https://www.riverbankcomputing.com/static/Downloads/sip/${MODPY_EGG_VERSION}/

MODULES= lang/python

@@ -43,6 +43,12 @@
SUBST_VARS += MODPY_LIB_SUFFIX
pre-configure:
${SUBST_CMD} ${WRKSRC}/configure.py
+
+# mk_distinfo.py tries to open sip_bin but it hasnt been renamed yet
+.if ${FLAVOR:Mpython3}
+pre-fake:
+ cd ${PREFIX}/bin && ln -sf sip sip${MODPY_BIN_SUFFIX}
+.endif

post-install:
${MODPY_BIN} ${MODPY_LIBDIR}/compileall.py ${WRKINST}${MODPY_SITEPKG}
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/py-sip/distinfo,v
retrieving revision 1.16
diff -u -r1.16 distinfo
--- distinfo 17 Jul 2017 08:34:39 -0000 1.16
+++ distinfo 26 Jun 2019 16:05:19 -0000
@@ -1,2 +1,2 @@
-SHA256 (sip-4.19.3.tar.gz) = dA34RPgMxF3MmyMpSpJJKSO8QDzojmjDV4PyfBd8S3Q=
-SIZE (sip-4.19.3.tar.gz) = 1007481
+SHA256 (sip-4.19.17.tar.gz) = ErzY9NX+78EFvAddEsUJDueD9zgHKFY8kbi5XQ7EXfM=
+SIZE (sip-4.19.17.tar.gz) = 1056156
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/py-sip/pkg/PLIST,v
retrieving revision 1.9
diff -u -r1.9 PLIST
--- pkg/PLIST 17 Jul 2017 08:34:39 -0000 1.9
+++ pkg/PLIST 26 Jun 2019 16:05:19 -0000
@@ -1,10 +1,14 @@
@comment $OpenBSD: PLIST,v 1.9 2017/07/17 08:34:39 zhuk Exp $
@bin bin/sip${MODPY_BIN_SUFFIX}
include/python${MODPY_VERSION}${MODPY_LIB_SUFFIX}/sip.h
-lib/python${MODPY_VERSION}/site-packages/sip.pyi
${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}sipconfig.${MODPY_PYC_MAGIC_TAG}pyc
lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}sipdistutils.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/
+lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/INSTALLER
+lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/METADATA
+lib/python${MODPY_VERSION}/site-packages/sip-${MODPY_EGG_VERSION}.dist-info/RECORD
+lib/python${MODPY_VERSION}/site-packages/sip.pyi
lib/python${MODPY_VERSION}/site-packages/sip.so
lib/python${MODPY_VERSION}/site-packages/sipconfig.py
lib/python${MODPY_VERSION}/site-packages/sipdistutils.py
On Wed, Jun 26, 2019 at 06:06:45PM +0200, Landry Breuil wrote:
> On Sun, Jun 23, 2019 at 05:23:38PM +0200, Landry Breuil wrote:
> > Hi,
> >
> > here's an update to py-sip-4.19.17, two years of changes since the
> > 4.19.3 we have. It seems i need it for qgis 3.8, which trips on "enum
> > class foo" constructs, apparently supported since 4.19.4 per
> > https://www.riverbankcomputing.com/static/Docs/sip/incompatibilities.html#sip-v4-19-4
> >
> > will throw it in a bulk, but ppl using sip/qt/python software should
> > definitely check for runtime issues.
>
> new diff with an improved pre-fake target. Went into a bulk build
> without apparent issue, but got zero feedback from runtime testing.
> qgis 3.8.0 works with it.

ping - comments from the python crowd welcome. Otherwise i'll just
commit it, and see if something breaks at runtime in a consumer.

Landry