On Mon, Jul 29, 2019 at 09:19:48PM -0400, Brian Callahan wrote:
> Added mailer.conf as an example config.
> I thought I had included dma.conf but I guess not. It's there now. Both
> dma.conf and auth.conf are @sample'd into the correct place
> (${SYSCONFDIR}/dma/) but I chose not to @sample mailer.conf, as systems come
> with a /etc/mailer.conf by default.
Seems good.
> I did. This port is my own fork of dma because of a bunch of FreeBSD/DFly
> compat that had to be included and I would have to modify either Makefile no
> matter which way I went so I chose to modify ${WRKSRC}/Makefile to make my
> life easier. So I simply did the right thing for an install target in
> ${WRKSRC}/Makefile too now so the do-install target goes away.
>
> Additionally, there are some fixes in the updated attached tarball.
Your new tarball lacks a `do-install' target but has no patches to any
Makefile, does that mean you incorporated the fixes into your tarball?
A bit confusing because I have no way to tell which bits came from
upsreamand which ones you added/modified.
That said, if it's your fork I'd prefer upstream (you) to carry
modifications instead of having them under patches/ in the port, but
some from of comment or DESCR addition stating that could be helpful.
Especially since you link to Dragonfly's official site as HOMEPAGE, not
yours.
No comments:
Post a Comment