On 2019/08/02 18:01, Kirill Bychkov wrote:
> On Fri, August 2, 2019 15:57, Stuart Henderson wrote:
> > seafile keep pushing new commits to tags (using them something like
> > branches). New fetches are broken in -current for libsearpc and client
> > and because the distfile was changed in ${FULLDISTDIR} without renaming
> > it, there are problems sharing distfiles between current and stable
> > builds. (Everyone: please if you are "regenerating distinfo" because
> > upstream re-rolled things, make sure the filenames that we use are
> > changed!)
> >
> > Kirill, is this ok with you?
>
> Looks good to me. Thanks for your work!
>
> >
> > - use GH_COMMIT everywhere to avoid this problem happening again
> > (-server was still OK but I don't trust them not to touch that).
> > we're still at risk of distfiles changing due to github updates but
> > that seems less common,
> >
> > - move all the GH_* to subdirs,
> >
> > - use a common (and recent) autoconf/automake version, seems silly to
> > have various subports using different versions.
>
> Also makes sense except that fact that client is using cmake. Shoould
> we just sync AUTOHELL_VERSIONs in libsearpc and daemon without setting
> them in Makefile.inc?
That's not a problem, AUTO*_VERSION doesn't do anything unless
there's a gnu-ish CONFIGURE_STYLE.
No comments:
Post a Comment