Re: [Update] converters/py-html2text : Update to 2019.8.11

On 2019/08/18 11:37, Kurt Mosiejczuk wrote:
> On Sun, Aug 18, 2019 at 01:58:30AM +0000, wen heping wrote:
>
> > Hi, ports@:
>
> > Here is a patch for converters/py-html2text: i)update to 2019.8.11
> > ii) define NO_TEST=yes. Now py-html2text use tox to do regression
> > tests, so I mark NO_TEST=yes. But all tests passed when I use tox to
> > do regression tests manually.
>
> It *can* use tox to do regression tests, but it doesn't need it. Even
> if it did need it, then one should add the dependency and make it use it.
>
> However, in this case, defining MODPY_PYTEST=Yes is sufficient to make
> all the tests work again. There is no reason to disable tests here.
>
> > Only one port depends on converters/py-html2text :
> > mail/rss2email. It build and run well with this update.
>
> There's more than mail/rss2email.
> www/urlwatch
> productivity/tryton
> www/odoo
> www/weboob

wen, this is the second recent submitted diff where dependent ports were
missed, how are you finding these?


> > Comments? OK?
>
> The new version also needs FIX_EXTRACT_PERMISSIONS.

set PORTS_PRIVSEP=Yes in /etc/mk.conf. it will need some permission
changes on build directories etc, but it's safer, and it will be easier
to notice ports that need FIX_EXTRACT_PERMISSIONS (rss2email didn't
build at all without setting this), plus if you use the default
pf.conf "block" rules for user _pbuild it will be easier to notice
if a port tries to fetch things from the internet (python auto
fetching dependencies, etc).