Monday, September 30, 2019

Re: Add rc file for nfcapd and a stubREADME

On 2019/09/30 12:39, Ville Valkonen wrote:
> On Mon, 30 Sep 2019 at 02:29, Stuart Henderson <stu@spacehopper.org> wrote:
> >
> > On 2019/09/29 16:26, Ville Valkonen wrote:
> > > Week+ ping? Cc'ing Stuart as he's the maintainer of nfdump port.
> >
> > Yes you should definitely cc the maintainer - but no diff,
> > and the inline parts in the quoted mail are not usable directly (missing
> > headers, hardcoded paths that should come from variables)..
>
> Hello Stuart,
>
> please see the original email below.

Yes I saw that, but they're not usable directly, the proposed README is
not in the same format that every other pkg-readme in the tree uses, the
proposed README and rc script have hardcoded paths that should come from
variables, and it's not in the form of a diff so it would need to be hand
applied which is a pain.

> I came to realize that custom flags will omit the default flags. Not
> sure if that's the problem but we could use the similar approach that
> unbound has where user flags are concatenated to the default flags.
>
> <snip>
> Hello,
>
> please CC me as I'm not subscribed in to the ports mailing list.
>
> Here's [1] an rc script for nfcapd daemon which is part of the nfdump package.
>
> And while here, document nfexpire in some level in README [2].
>
> Comments?
>
>
> [1]
> <snip>
> #!/bin/ksh
>
> daemon="/usr/local/bin/nfcapd -D"
> daemon_user="_nfcapd"
> daemon_flags="-l /var/cache/nfcapd -P /var/run/nfcapd/nfcapd.pid"
>
> rc_reload=NO
>
> . /etc/rc.d/rc.subr
>
> rc_pre() {
> /usr/bin/install -d -o ${daemon_user} /var/run/nfcapd
> }
>
> rc_cmd $1
> </snip>
>
> [2]
> It should be noted that nfcapd can fill disk rather quickly in vibrant network
> environments. Therefore it's important to flush the flow stats every now and
> then. One could use the following root's crontab entry to expire flows older
> than 31 days:
> @daily /usr/local/bin/nfexpire -t 31d /var/cache/nfcapd >/dev/null 2>&1
>
> --
> Kind regards,
> Ville Valkonen
> </snip>
>
> Regards,
> Ville

No comments:

Post a Comment