Sunday, September 01, 2019

Re: devel/shellcheck update for ghc 8.6.4

On Mon, Jun 3, 2019 at 11:03 AM Caspar Schutijser <caspar@schutijser.com>
wrote:

> On Sun, Jun 02, 2019 at 03:06:28PM -0700, Greg Steuck wrote:
> > In my quest to update the ports [tree] to ghc 8.6.4 I arrived at a fork
> re
> > ShellCheck.
> >
> > The first blocker is ANN/TemplateHaskell is [broken] enough that
> > patching is required to get rid of all ShellCheck testing code.


This has been resolved by switching to the system linker instead of GHC
internal one
(
https://github.com/blackgnezdo/ports/commit/f5997dfde3ef5620d54d046dd9708dc441f09322
)


> > the next snag is the ancient version of ShellCheck in ports. At least
> > a couple of places need to be patched for Semigroup and MonadFail
> > issues. My natural impulse would be to upgrade ShellCheck to the most
> > recent version 0.6.0, except it has a larger dependency
> > set and at least aeson is not in ports. At this point I'm not sure
> > which way to go. Is the new version with a larger set of deps a better
> > option? Or the patched-up old version?


I ended up patching the old version to build with 8.6
(
https://github.com/blackgnezdo/ports/commit/51888cfbf1dad9485f1bf4cb41a2cd1ccc386ac3
)
It was the easiest thing to do for now though maybe removing
ShellCheck would've been a better long term move.

Thanks
Greg

No comments:

Post a Comment