Re: Enable tests for devel/bpython

On Fri, Aug 02, 2019 at 12:06:25AM -0400, Brian Callahan wrote:

> If they work, sure.

Swinging back to this, the tests didn't quite work before. One of them
would just hang forever. So I didn't commit it. However, I've got them
working now. I ended up patching the three hanging tests out by labeling
them as something to skip. It's an inelegant hammer, but I spent hours
trying to get these to work, and I'd rather have all but 3 of the tests
versus none of them.

OK?

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/bpython/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- Makefile 9 Aug 2019 00:00:40 -0000 1.25
+++ Makefile 22 Sep 2019 21:02:27 -0000
@@ -35,10 +35,8 @@ RUN_DEPENDS= devel/desktop-file-utils \
BUILD_DEPENDS= devel/py-babel${MODPY_FLAVOR} \
textproc/py-sphinx${MODPY_FLAVOR}

-# axe tests until py-twisted+deps have a python3 flavor
-NO_TEST = Yes
-#TEST_DEPENDS= devel/py-mock${MODPY_FLAVOR} \
-# devel/py-twisted${MODPY_FLAVOR}
+TEST_DEPENDS= devel/py-mock${MODPY_FLAVOR} \
+ devel/py-twisted${MODPY_FLAVOR}

# de-conflict flavors
post-install:
Index: patches/patch-bpython_test_test_args_py
===================================================================
RCS file: patches/patch-bpython_test_test_args_py
diff -N patches/patch-bpython_test_test_args_py
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-bpython_test_test_args_py 22 Sep 2019 21:02:27 -0000
@@ -0,0 +1,31 @@
+$OpenBSD$
+
+Skip three tests that just hang forever
+
+Index: bpython/test/test_args.py
+--- bpython/test/test_args.py.orig
++++ bpython/test/test_args.py
+@@ -20,6 +20,7 @@ except ImportError:
+
+ @attr(speed='slow')
+ class TestExecArgs(unittest.TestCase):
++ @unittest.skip("hangs under OpenBSD")
+ def test_exec_dunder_file(self):
+ with tempfile.NamedTemporaryFile(mode="w") as f:
+ f.write(dedent("""\
+@@ -37,6 +38,7 @@ class TestExecArgs(unittest.TestCase):
+
+ self.assertEqual(stderr.strip(), f.name)
+
++ @unittest.skip("hangs under OpenBSD")
+ def test_exec_nonascii_file(self):
+ with tempfile.NamedTemporaryFile(mode="w") as f:
+ f.write(dedent('''\
+@@ -52,6 +54,7 @@ class TestExecArgs(unittest.TestCase):
+ except subprocess.CalledProcessError:
+ self.fail('Error running module with nonascii characters')
+
++ @unittest.skip("hangs under OpenBSD")
+ def test_exec_nonascii_file_linenums(self):
+ with tempfile.NamedTemporaryFile(mode="w") as f:
+ f.write(dedent("""\