Re: games/widelands build output explosion

On Wed Sep 04, 2019 at 09:17:43PM +0200, Christian Weisgerber wrote:
> Rafael Sadowski:
>
> > With my patch the build creates ~1-2MB log file without ~316MB.
> > What's wrong with disabling these flags?
>
> Before the cmake 3.15 change the port used the same flags but did
> not spew so many compiler warnings. Clearly the actual problem is
> with the the cmake change, but you want to sweep it under the carpet.
>
> --
> Christian "naddy" Weisgerber naddy@mips.inka.de
>

I built widelands without any warnings with the diff below. That was
simple.

OK?

Index: Makefile
===================================================================
RCS file: /cvs/ports/games/widelands/Makefile,v
retrieving revision 1.27
diff -u -p -u -p -r1.27 Makefile
--- Makefile 28 Aug 2019 14:12:49 -0000 1.27
+++ Makefile 5 Sep 2019 18:20:50 -0000
@@ -1,15 +1,13 @@
# $OpenBSD: Makefile,v 1.27 2019/08/28 14:12:49 naddy Exp $

COMMENT= economic and military simulation game
-BROKEN-sparc64= generates 240Mb log with 'terminate called recursively'
-BROKEN= excessive warnings generate a 319 MB log file

V = 20
DISTNAME = widelands-build${V}
PKGNAME= widelands-0.${V}
CATEGORIES= games
EXTRACT_SUFX= .tar.bz2
-REVISION= 0
+REVISION= 1

HOMEPAGE= https://wl.widelands.org/
MASTER_SITES = https://launchpad.net/widelands/build${V}/build${V}/+download/
@@ -45,9 +43,7 @@ CONFIGURE_ARGS = -DWL_INSTALL_DATADIR=${
-DWL_INSTALL_BASEDIR=${PREFIX}/share/widelands \
-DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=ON

-CONFIGURE_ENV = CXXFLAGS="${CXXFLAGS} -I${LOCALBASE}/include \
- -I${X11BASE}/include" \
- LDFLAGS="${LDFLAGS} -lGL -lexecinfo -lintl -liconv \
+CONFIGURE_ENV = LDFLAGS="${LDFLAGS} -lGL -lexecinfo -lintl -liconv \
-L${LOCALBASE}/lib -L${X11BASE}/lib"

NO_TEST= Yes