Re: math/coq: bash dependency missing...

On 2019/09/11 08:58, Yozo TODA wrote:
> hi, trying to build math/coq (8.10+beta2) I found it failed.
>
> ......
> OCAMLC ide/coqide.mli
> OCAMLOPT ide/coqide.ml
> OCAMLOPT -a -o ide/ide.cmxa
> OCAMLC ide/coqide_os_specific.mli
> OCAMLOPT ide/coqide_os_specific.ml
> OCAMLOPT -o bin/coqide
> CHECK revision
> env: bash: No such file or directory
> gmake[1]: *** [Makefile.dev:34: revision] Error 127
> gmake[1]: Leaving directory '/usr/ports/pobj/coq-8.10beta2/coq-8.10-beta2'
> gmake: *** [Makefile:176: submake] Error 2
> *** Error 2 in . (Makefile:58 'do-build')
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2777 '/usr/ports/pobj/coq-8.10beta2/.build_done')
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2002 '/usr/ports/packages/amd64/all/coq-8.10beta2.tgz')
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2468 '_internal-package')
> *** Error 1 in /usr/ports/math/coq (/usr/ports/infrastructure/mk/bsd.port.mk:2447 'package')
> Mon Sep 9 17:31:51 JST 2019
>
>
> adding shells/bash to BUILD_DEPENDS, make package works.
>
> --- coq/Makefile-1.41 Sat Sep 7 09:29:29 2019
> +++ coq/Makefile Wed Sep 11 08:46:46 2019
> @@ -25,6 +25,7 @@
>
> BUILD_DEPENDS= x11/lablgtk3 \
> math/ocaml-num \
> + shells/bash \
> sysutils/findlib
> RUN_DEPENDS= x11/lablgtk3

I committed that addition earlier (though haven't re-tried the build yet
so there could be another problem lurking, but that one was obvious).

> with this patch, make test still fails.
> the log indicates that there's use of some invalid options to diff command.
> I don't dig into details yet but suppose those options are for gnu diff?

"--strip-trailing-cr" etc? yes that's for gnu diff. That needs a
TEST_DEPENDS addition, and either patch to use gdiff in the file (likely
to get outdated easily) or symlink gdiff into ${WRKDIR}/bin/diff in pre-test.

> anyway, bash should be added to BUILD_DEPENDS.
>
> -- yozo.
>