Tuesday, September 17, 2019

Re: mupdf: fix space and backspace keys

On Tue, Sep 17, 2019 at 09:50:23AM +0100, Stuart Henderson wrote:
> On 2019/09/17 10:45, Theo Buehler wrote:
> > The space key on the penultimate page doesn't work due to an off-by-one.
> > This is a genuine bug.
>
> OK.

For the record: https://bugs.ghostscript.com/show_bug.cgi?id=701615

> > The backspace mapping was apparently deliberately removed (just like
> > '\r', '\n', '=', 'L', 'R' and perhaps others), so I'm less sure we
> > should fix it. Diff below contains the trivial fix for it as well.
>
> There are enough assorted random patches in mupdf anyway I don't think
> it hurts to add this extra small one. To help trigger my memory when
> I merge patches in the future, could you add /* backspace */ on the
> line please? \b is uncommon enough that I won't recognise it directly.

Of course, I'll do that.

No comments:

Post a Comment