Re: New devel/py-base58

On Mon, Sep 23, 2019 at 01:28:31AM +0200, clematis wrote:
> On Sat, Sep 21, 2019 at 06:08:38PM -0400, Kurt Mosiejczuk wrote:
> > COMMENT isn't supposed to start with a capital as a general rule
> > devel has lots of entries and we try to put new ports elsewhere is they
> > fit somewhere else. Maybe converters?
> Hi Kurt,
> OK - thanks for the informations.

> > The tests do not run for me at all. Either flavor.
> I've added the: TEST_DEPENDS = devel/py-hamcrest${MODPY_FLAVOR}

> make test = Ran 0 tests
> the 14 passed was running py.test in pobj/
> which might still be pointless.

It is easily fixed by specifying MODPY_PYTEST = Yes

Setuptools isn't configured by base58 to run tests. pytest figures it
out though. (Not something I'd have expected you to know at this stage).

All tests pass for both flavors on amd64 and sparc64.

> New tarball attached:
> - remove capital in COMMENT
> - CATEGORIES = converters
> - adding TEST_DEPENDS

The above changes are good.

I edited the DESCR a bit. Their (base58) wording was a bit awkward.

When I checked if PLIST was right it shuffled one line to the top. Not
real important, but I figure do it now rather than later.

I've attached a tarball with my tweaks. They were just tweaks though.
Did you want to take maintainer on it?

--Kurt